Fix the PHP 8.0 compatibility problems, including errors and notices.

CommentFileSizeAuthor
#2 backup_migrate-n3213452-2.patch601 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new backup_migrate-n3213452-2.patch601 bytes

One notice that shows:

  • Deprecated: Required parameter $settings follows optional parameter $level in includes/filters.compression.inc on line 105
solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. It's also only called in one place, and the parameter 9 is used.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

WhY iS iT nOt WoRkInG?!?

solideogloria’s picture

solideogloria commented

Does it work if you change the parameter order so the optional one is last, and change it back to $level = 9?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

I was wondering why the tests were failing :-\

Committed.

  • DamienMcKenna committed 4bb0869 on 7.x-3.x 
    Issue #3213452 by DamienMcKenna, solideogloria: PHP 8.0 compatibility.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.