Problem/Motivation

Olivero: Label and input field in the quick-edit toolbar does not have a space between them which makes them odd and the focus of the input field overlaps with the label.

Steps to reproduce

1. Go to any node.
2. Quick edit the node, the content type of the specific node page must contain an image field.
3. Hover the mouse on the image.
4. You will see the quick-edit toolbar with the label name alternative text and input field.
5. There is no space between the label and the input field, the focus of the input field overlaps the label.

Please refer the video attached for reference.

Comments

tushar_sachdeva created an issue. See original summary.

sakthivel m’s picture

Status: Active » Needs review
StatusFileSize
new834 bytes

#2 Please review the patch

tushar_sachdeva’s picture

StatusFileSize
new155.27 KB
new160.13 KB

@Sakthivel M thanks for the patch it works fine, attaching before and after patch screenshots.

chetanbharambe’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new499.03 KB
new1.26 MB

Verified and tested patch #2.
Patch applied successfully and looks good to me.

Testing Steps:
# Go to any node.
# Quick edit the node, the content type of the specific node page must contain an image field.
# Hover the mouse on the image.
# You will see the quick-edit toolbar with the label name alternative text and input field.
# There is no space between the label and the input field, the focus of the input field overlaps the label.

Expected Results:
# There should be some space between the label and the input field.

Actual Results:
# There is no space between the label and the input field, the focus of the input field overlaps the label.

Looks good to me.
Can be a move to RTBC.

mherchel’s picture

Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work

Note that Quickedit will be deprecated. See #3222947: Decide whether to move Quick Edit to contrib. We'll want to move any changes into their own stylesheet, so we can easily remove them if necessary.

kostyashupenko’s picture

Status: Needs work » Needs review
StatusFileSize
new1.88 KB
xjm’s picture

Priority: Minor » Normal

Normal priority bug under the normal issue priority definition:

Bugs for site visitors that do not interfere with site use, for example, visual layout issues.

abhijith s’s picture

StatusFileSize
new18.02 KB
new16.62 KB

Applied patch #6 and it works fine. There is now a gap between the label name alternative text and input field.

Before patch;
before

After patch:
after

RTBC +1

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Aamir M’s picture

Assigned: Unassigned » Aamir M
Aamir M’s picture

Assigned: Aamir M » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new257.53 KB
new262.11 KB

Patch #6 has not worked for me it's showing the (patch failed) when I am trying to apply it.
Verified and tested patch #2 on Drupal 9.5.x-dev. The patch was applied successfully and looks good to me.

Testing Steps:
1. Make sure the Quick Edit module was enabled
2. Go to any node.
3. Quick edit the node, the content type of the specific node page must contain an image field.
4. Hover the mouse on the image.
5. You will see the quick-edit toolbar with the label name alternative text and input field.
6. There is no space between the label and the input field, the focus of the input field overlaps the label.
7. Apply the patch
8. Reload the page. (Note: Clear all caches if required)
9. Now observe the space between the label and the input field

Testing Result:
1. After applying the patch the space between the label and the input field is displayed properly

Screenshots are attached for the reference
Hence moved to RTBC

vinaymahale’s picture

StatusFileSize
new133.91 KB

Patch #6 failed to apply for D9.5.x-dev
Patch #2 applied successfully and fixes the issue for D9.5.x-dev

Space fix

Please note: "Quick Edit" module will be deprecated in the next major release of Drupal
The solution for this issue needs to be modified accordingly

quietone’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

The patch being tested is testing on a branch that is only getting security fixes. This needs a patch for 9.5.x, and according to the testbot it does not apply to 9.5. Adding tag for a reroll.

I see multiple sets of screenshots on the same patch. I am removing credit for the latest duplicate screenshots according to How is credit granted for Drupal core issues.

medha kumari’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new834 bytes

Reroll the patch #2 with Drupal 9.5.x

asha nair’s picture

StatusFileSize
new18.7 KB
new12.42 KB

Patch #15 works fine in Drupal 9.5.x. Adding screenshots for reference

Manibharathi E R’s picture

StatusFileSize
new227.73 KB
new360.18 KB

Patch #15 Tested and Applied successfully on Drupal 9.5.x.

shyam_bhatt’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new81.97 KB
new53.97 KB

Patch #15 Tested and Applied successfully on Drupal 9.5.x. It's working on Drupal 10.1.x as well.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 15: 3213158.15.patch, failed testing. View results

narendra.rajwar27’s picture

Status: Needs work » Needs review
StatusFileSize
new1.88 KB

Re-rolled the patch in comment #6.

Status: Needs review » Needs work

The last submitted patch, 20: 3213158-20.patch, failed testing. View results

ravi.shankar’s picture

Status: Needs work » Needs review
StatusFileSize
new1.88 KB
new581 bytes

Fixed failed test of patch #20.

Status: Needs review » Needs work

The last submitted patch, 22: 3213158-22.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vinaymahale’s picture

Any updates over here?

Harish1688’s picture

Status: Needs work » Needs review
StatusFileSize
new1.96 KB
new179.31 KB

Hi,

The recent patches #20 and #22 have failed, so we need to re-roll the patch based on core 10 and 11. The following points should be considered:
1. As mentioned in #5, since Quick Edit will be deprecated, any changes should be made in their respective stylesheets.
2. Both LTR and RTL cases have been tested and are functioning correctly.

issue image

smustgrave’s picture

Status: Needs review » Needs work

Please include interdiffs with your patches.

Harish1688’s picture

Status: Needs work » Needs review
StatusFileSize
new920 bytes
new1.81 KB

Hi @smustgrave ,

I apologies for the previous patch failure in #27. I forget to include the files in the patch and also to add the interdiff.
I will now upload the new patch (3213158-29.patch) along with the interdiff.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new2.58 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Status: Needs work » Postponed

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.

quietone’s picture

Project: Drupal core » Olivero
Version: main » 2.0.0
Component: Olivero theme » Code
Status: Postponed » Needs work
quietone’s picture

Version: 2.0.0 » 2.x-dev