Needs work
Project:
Olivero
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 May 2021 at 11:15 UTC
Updated:
2 Oct 2026 at 10:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sakthivel m commented#2 Please review the patch
Comment #3
tushar_sachdeva commented@Sakthivel M thanks for the patch it works fine, attaching before and after patch screenshots.
Comment #4
chetanbharambe commentedVerified and tested patch #2.
Patch applied successfully and looks good to me.
Testing Steps:
# Go to any node.
# Quick edit the node, the content type of the specific node page must contain an image field.
# Hover the mouse on the image.
# You will see the quick-edit toolbar with the label name alternative text and input field.
# There is no space between the label and the input field, the focus of the input field overlaps the label.
Expected Results:
# There should be some space between the label and the input field.
Actual Results:
# There is no space between the label and the input field, the focus of the input field overlaps the label.
Looks good to me.
Can be a move to RTBC.
Comment #5
mherchelNote that Quickedit will be deprecated. See #3222947: Decide whether to move Quick Edit to contrib. We'll want to move any changes into their own stylesheet, so we can easily remove them if necessary.
Comment #6
kostyashupenkoComment #7
xjmNormal priority bug under the normal issue priority definition:
Comment #8
abhijith s commentedApplied patch #6 and it works fine. There is now a gap between the label name alternative text and input field.
Before patch;

After patch:

RTBC +1
Comment #11
Aamir M commentedComment #12
Aamir M commentedPatch #6 has not worked for me it's showing the (patch failed) when I am trying to apply it.
Verified and tested patch #2 on Drupal 9.5.x-dev. The patch was applied successfully and looks good to me.
Testing Steps:
1. Make sure the Quick Edit module was enabled
2. Go to any node.
3. Quick edit the node, the content type of the specific node page must contain an image field.
4. Hover the mouse on the image.
5. You will see the quick-edit toolbar with the label name alternative text and input field.
6. There is no space between the label and the input field, the focus of the input field overlaps the label.
7. Apply the patch
8. Reload the page. (Note: Clear all caches if required)
9. Now observe the space between the label and the input field
Testing Result:
1. After applying the patch the space between the label and the input field is displayed properly
Screenshots are attached for the reference
Hence moved to RTBC
Comment #13
vinaymahale commentedPatch #6 failed to apply for D9.5.x-dev
Patch #2 applied successfully and fixes the issue for D9.5.x-dev
Please note: "Quick Edit" module will be deprecated in the next major release of Drupal
The solution for this issue needs to be modified accordingly
Comment #14
quietone commentedThe patch being tested is testing on a branch that is only getting security fixes. This needs a patch for 9.5.x, and according to the testbot it does not apply to 9.5. Adding tag for a reroll.
I see multiple sets of screenshots on the same patch. I am removing credit for the latest duplicate screenshots according to How is credit granted for Drupal core issues.
Comment #15
medha kumariReroll the patch #2 with Drupal 9.5.x
Comment #16
asha nair commentedPatch #15 works fine in Drupal 9.5.x. Adding screenshots for reference
Comment #17
Manibharathi E R commentedPatch #15 Tested and Applied successfully on Drupal 9.5.x.
Comment #18
shyam_bhattPatch #15 Tested and Applied successfully on Drupal 9.5.x. It's working on Drupal 10.1.x as well.
Comment #20
narendra.rajwar27Re-rolled the patch in comment #6.
Comment #22
ravi.shankar commentedFixed failed test of patch #20.
Comment #26
vinaymahale commentedAny updates over here?
Comment #27
Harish1688 commentedHi,
The recent patches #20 and #22 have failed, so we need to re-roll the patch based on core 10 and 11. The following points should be considered:
1. As mentioned in #5, since Quick Edit will be deprecated, any changes should be made in their respective stylesheets.
2. Both LTR and RTL cases have been tested and are functioning correctly.
Comment #28
smustgrave commentedPlease include interdiffs with your patches.
Comment #29
Harish1688 commentedHi @smustgrave ,
I apologies for the previous patch failure in #27. I forget to include the files in the patch and also to add the interdiff.
I will now upload the new patch (3213158-29.patch) along with the interdiff.
Comment #30
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #32
quietone commentedThe Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.
Comment #33
quietone commentedComment #34
quietone commented