Please consider replacing ‘whitelist’ with ‘allow list.’ Thank you.
Tasks
- Backport to 7.x
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3211223-11.patch | 3.9 KB | neslee canil pinto |
| #9 | made-changes-to-comments-3211223-9.patch | 6.47 KB | anjali rathod |
| #5 | no_whitelist2.png | 16.33 KB | guilhermevp |
| #5 | no-whitelist.png | 58.32 KB | guilhermevp |
| #4 | changed-whitelist-allow-list-3211223-4.patch | 3.61 KB | anjali rathod |
Comments
Comment #2
rocketeerbkw commentedThanks, I'll accept patches with this change. I think it only exists in the code comments and on the project page.
Comment #3
anjali rathodComment #4
anjali rathodCouldn't get the words with blacklist, made the changes for whitelist. Please review and add any needed comments
Comment #5
guilhermevp commentedPatch applies cleanly and remove all whitelist related mentions.
Comment #6
nicrodgersThanks for your contribution!
I've reviewed the changes, and highlight below some further changes to improve readability. Currently some of the changes don't read correctly, nor are they grammatically correct.
this doesn't read properly.
How about:
In general, this module can be used to prevent logging in by users unless their IP address is on the allowed list.
to IP addresses on the allowed list
listlist -> list
listlist -> list
based on the IP allow list
based on the IP allow list
on the IP allow list.
Comment #7
nicrodgersUpdated the issue summary to only reference the removal of 'whitelist' as there is currently no mention of 'blacklist' in the codebase, so nothing needs removing there.
Comment #8
anjali rathodComment #9
anjali rathodThanks for the update!
I have made the changes. Please review ! :)
Comment #10
nicrodgersHi Anjali,
Nearly there I think. Just a few things left that I've spotted:
Restrict logins or roles to IP addresses on the allowed list
these lines need reformatting so they are under 80 characters (to comply with drupal coding standards)
there seem to be a lot of chmod/mode changes in this latest diff (like this one) that are unrelated and need removing
Comment #11
neslee canil pintoComment #12
nicrodgersLooks good, nice work everyone.
Comment #15
rocketeerbkw commentedThanks all, I committed the patch and reworked the README. Moving issue to 7.x for backporting.
Comment #17
rocketeerbkw commentedComment #18
darvanenAs Drupal 7 is no longer supported I'm moving this to fixed.