Problem/Motivation

Include reset button on Custom block library page(/admin/structure/block/block-content) when any filter selected by admin/editor.

Proposed resolution

Update 'Custom block library' view to enable 'Reset' button.

Remaining tasks

None

User interface changes

For admin, 'Reset' button rendering on /admin/structure/block/block-content page.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#9 Screenshot 2021-04-16 at 16.55.07.png57.05 KBgauravvvv
#8 Custom-block-library-Custom-block-D9.png89.37 KBnikhil banait
#7 after-patch.mp47.24 MBbhumikavarshney
#7 applying-patch.png19.84 KBbhumikavarshney
#4 3207405-after_patch.png125.34 KBabhijith s
#2 3207405-2.patch624 bytesnikhil banait

Comments

Nikhil Banait created an issue. See original summary.

nikhil banait’s picture

nikhil banait commented
StatusFileSize
new 3207405-2.patch624 bytes

Added patch.

nikhil banait’s picture

nikhil banait commented
Status: Active » Needs review
abhijith s’s picture

abhijith s commented
StatusFileSize
new 3207405-after_patch.png125.34 KB

Applied patch #2 and its working fine,The reset button is appearing in the custom blocks view .

After patch :
after

RTBC +1

guilhermevp’s picture

guilhermevp commented

Weird, applied the patch, cleared cache but the button didn't rendered. I wonder what went wrong. That said, this will probably needs an usability review.

nikhil banait’s picture

nikhil banait commented

@guilhermevp In order to render the Reset button, either you have to select any filter or simply click on Apply button.

bhumikavarshney’s picture

bhumikavarshney commented
StatusFileSize
new applying-patch.png19.84 KB
new after-patch.mp47.24 MB

Hi @Nikhil Banait
Am also facing the same issue, applied the patch, cleared cache but the button didn't rendered.
Also tried your solution you have suggested
" In order to render the Reset button, either you have to select any filter or simply click on Apply button."

nikhil banait’s picture

nikhil banait commented
StatusFileSize
new Custom-block-library-Custom-block-D9.png89.37 KB

@BhumikaVarshney Thanks for testing this patch. Looks like patch did not get apply correctly. In order to check that, please browse to '/admin/structure/views/view/block_content' and in 'Advance' section click on 'Setting' link under 'Exposed From'. Now check if 'Include reset button (resets all applied exposed filters)' is checked or not.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screenshot 2021-04-16 at 16.55.07.png57.05 KB

The reset button is showing in the custom blocks view.

Attaching an after-patch screenshot for reference.

Moving to RTBC.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3207405-2.patch, failed testing. View results

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Restoring status after HEAD was broken.

  • catch committed bf132da on 9.3.x 
    Issue #3207405 by Nikhil Banait, Gauravmahlawat, Abhijith S: Add 'Reset...

  • catch committed 3143869 on 9.2.x 
    Issue #3207405 by Nikhil Banait, Gauravmahlawat, Abhijith S: Add 'Reset...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

This isn't something to add an update for - would add complexity to the patch for something that is easy to configure in the UI. But it'll improve usability for new sites.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.