Problem/Motivation

With the Drupal 7 Date Repeat module, "yearly" is a choice for how a date repeats. Might it make sense to add support for yearly events to this module?

Proposed resolution

Add "Yearly" as a "Recur Type" option.

Data model changes

As architected now, this would probably require more fields to be added to the base eventseries_field_data table.

CommentFileSizeAuthor
#3 Screenshot-20210204-15.26.11.png82.78 KBjrb

Issue fork recurring_events-3196417

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jrb created an issue. See original summary.

owenbush’s picture

owenbush commented

Thanks for the issue. Yearly recurrence has been on my mind for a while. I'd like to pick your brain a little more as to what that actually means in terms of options.

What types of yearly recurrence should there be? How does the D7 date repeat module work?

jrb’s picture

jrb
he/him
Primary language English
Location Raleigh-Durham Area, NC, USA
commented
StatusFileSize
new Screenshot-20210204-15.26.11.png82.78 KB

It looks pretty similar to "Monthly" events. See screenshot.

Screenshot of UI for entering a yearly event

owenbush’s picture

owenbush commented

Great, thank you for attaching that, it helps a lot.

muriqui made their first commit to this issue’s fork.

muriqui opened merge request !52

muriqui’s picture

muriqui commented
Status: Active » Needs work

Took a first shot at this in MR 52. Seems to work OK in initial testing, but would appreciate feedback. There's also a good bit of code duplication going on between the weekly, monthly, and (now) yearly plugins and their supporting methods on the EventSeries, which could stand to be refactored.

muriqui’s picture

muriqui commented
Status: Needs work » Needs review

  • owenbush committed 4bb3984e on 2.0.x authored by muriqui 
    Issue #3196417 by muriqui, owenbush, jrb: Add support for Annual/Yearly...

  • owenbush committed f0d763d4 on 8.x-1.x authored by muriqui 
    Issue #3196417 by muriqui, owenbush, jrb: Add support for Annual/Yearly...
owenbush’s picture

owenbush commented
Status: Needs review » Fixed

Nice work, I tested this out and it worked well. Thanks for the tests too.

And yes, I agree there's a lot of repeated code. I wish I could go back in time and make it a bit, less crap.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.