Just I was testing this module, it's not working for the text fields which set "unlimited" under "Allowed number of values" in field setting.
Also, not easy to configure for all the fields in website. We should provide for admins to configure in easy way, because instead of asking field machine name, it's required field id which is actually dynamic one.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | not_working_for_multi_valued_fields-3194871-4.patch | 5.84 KB | goyalsushant |
Comments
Comment #2
goyalsushant commentedComment #3
izmeez commentedAgreed. The settings are kinda hidden, not a proper admin interface and issues with various input fields, eg search input field works with barik theme but not others.
Comment #4
goyalsushant commentedThe issue for unlimited fields is their dynamic IDs. It can be handled using regex for defining field ID.
Attached is the patch for fixing the same.
Also, as mentioned by @izmeez I have tested it out on various fields and themes and it's working now.
Kindly check.
Comment #5
goyalsushant commentedComment #6
izmeez commentedI am removing the issue tag "fixed" as it is not committed to the module and that tag makes things confusing.
There is a lot of overlap between this patch and the patch in #3201151: Input Reset Does not work with ajax. Each patch takes a different approach and the patch in this issue addresses the extra issue of multi-valued fields. I am not sure if this patch should be broken into two with one addressing the ajax issue and the other the multi-valued fields. Both issues will be marked as related for now.
I have only done some limited testing with this patch and the one in the other issue.
Comment #7
rajveergangwarHi Everyone,
Can someone help patch review and mark it and working fine. So i can commit it to module