Problem/Motivation

Scrolling is frozen for a few seconds after clicking on a vertical tab

Steps to reproduce

When on a vertical tab on nodeform that is using vertical tabs, browser scrolling is temporarily disabled.

Proposed resolution

Don't rewrite the anchor link after click in core/misc/vertical-tabs.js - scrolling isn't usually necessary as the tab is next to the div that is revealed.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3188331-13.patch449 bytesgauravvvv
#8 vertical-tab-scroll-frozen-3188331-8.patch520 bytesnatedouglas
#4 vertical-tab-scroll-frozen-2.patch445 bytesethant
#3 vertical-tab-scroll-frozen-1.patch365 bytesethant
vertical-tab-scroll-frozen.patch445 bytesethant

Comments

EthanT created an issue. See original summary.

ethant’s picture

ethant
Location Sarasota, Florida
commented
ethant’s picture

ethant
Location Sarasota, Florida
commented
StatusFileSize
new vertical-tab-scroll-frozen-1.patch365 bytes
ethant’s picture

ethant
Location Sarasota, Florida
commented
StatusFileSize
new vertical-tab-scroll-frozen-2.patch445 bytes
ethant’s picture

ethant
Location Sarasota, Florida
commented
Issue summary: View changes
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 8.9.x-dev » 9.2.x-dev
Category: Feature request » Bug report

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

natedouglas’s picture

natedouglas commented
StatusFileSize
new vertical-tab-scroll-frozen-3188331-8.patch520 bytes

Rerolled vs. 9.3.x

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3188331-13.patch449 bytes

I have updated patch #8 for 11.x as it no longer applies to d11.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests
utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review

I tried reproducing this but i was not able to do that on 11.x .

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

I tried reproducing this but i was not able to do that on 11.x .

Can you detail a bit more about how you attempted to reproduce the issue? The above is unfortunately not enough information to help move the issue forward.

If something can't be reproduced it can be one of two things

  1. The reported problem is no longer an issue (or was something specific to their site)
  2. The attempt to reproduce was missing a step necessary to reproduce the issue

Currently there's no way of knowing if the inability to reproduce was due to reason 1 or reason 2.

utkarsh_33’s picture

utkarsh_33 commented

Here are the steps that i followed to reproduce the issue.
1)Visit node/add/article.
2)Click on the any of the vertical tabs for ex:- Menu settings.
3) Try scrolling on the page.

After following the above steps i didn't experience any lag in scrolling.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Closed (cannot reproduce)

I'll go with an issue in the specific site. I haven't seen an attribute change hold up the browser. It might be something unrelated (like a tracking script not optimized or something)

Closing unless someone can reproduce.