Problem/Motivation

src/Component/PositionedRectangle.php
349	The array declaration line has 83 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/AutoOrientImageEffect.php
152	The array declaration line has 84 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/BackgroundImageEffect.php
22	The class short comment should describe what the class does and not simply repeat the class name
185	The array declaration line has 183 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/ConvolutionImageEffect.php
64	The array declaration line has 81 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/ImagemagickArgumentsImageEffect.php
18	The class short comment should describe what the class does and not simply repeat the class name
105	The array declaration line has 83 characters (the limit is 80). The array content should be split up over multiple lines
106	The array declaration line has 85 characters (the limit is 80). The array content should be split up over multiple lines
117	The array declaration line has 93 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/InterlaceImageEffect.php
18	The class short comment should describe what the class does and not simply repeat the class name
src/Plugin/ImageEffect/MaskImageEffect.php
23	The class short comment should describe what the class does and not simply repeat the class name
175	The array declaration line has 94 characters (the limit is 80). The array content should be split up over multiple lines
176	The array declaration line has 96 characters (the limit is 80). The array content should be split up over multiple lines
189	The array declaration line has 171 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/ScaleAndSmartCropImageEffect.php
105	The array declaration line has 89 characters (the limit is 80). The array content should be split up over multiple lines
106	The array declaration line has 87 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/SetCanvasImageEffect.php
19	The class short comment should describe what the class does and not simply repeat the class name
src/Plugin/ImageEffect/SmartCropImageEffect.php
136	The array declaration line has 89 characters (the limit is 80). The array content should be split up over multiple lines
137	The array declaration line has 87 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/TextOverlayImageEffect.php
552	The array declaration line has 123 characters (the limit is 80). The array content should be split up over multiple lines
654	The array declaration line has 105 characters (the limit is 80). The array content should be split up over multiple lines
727	The array declaration line has 132 characters (the limit is 80). The array content should be split up over multiple lines
727	The array declaration line has 132 characters (the limit is 80). The array content should be split up over multiple lines
818	The array declaration line has 86 characters (the limit is 80). The array content should be split up over multiple lines
822	The array declaration line has 112 characters (the limit is 80). The array content should be split up over multiple lines
830	The array declaration line has 89 characters (the limit is 80). The array content should be split up over multiple lines
831	The array declaration line has 98 characters (the limit is 80). The array content should be split up over multiple lines
834	The array declaration line has 112 characters (the limit is 80). The array content should be split up over multiple lines
842	The array declaration line has 101 characters (the limit is 80). The array content should be split up over multiple lines
843	The array declaration line has 81 characters (the limit is 80). The array content should be split up over multiple lines
846	The array declaration line has 112 characters (the limit is 80). The array content should be split up over multiple lines
853	The array declaration line has 112 characters (the limit is 80). The array content should be split up over multiple lines
854	The array declaration line has 102 characters (the limit is 80). The array content should be split up over multiple lines
855	The array declaration line has 82 characters (the limit is 80). The array content should be split up over multiple lines
856	The array declaration line has 92 characters (the limit is 80). The array content should be split up over multiple lines
858	The array declaration line has 112 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffect/WatermarkImageEffect.php
23	The class short comment should describe what the class does and not simply repeat the class name
185	The array declaration line has 109 characters (the limit is 80). The array content should be split up over multiple lines
186	The array declaration line has 111 characters (the limit is 80). The array content should be split up over multiple lines
200	The array declaration line has 181 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageEffectsPluginManager.php
109	The array declaration line has 159 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageToolkit/Operation/gd/GDOperationTrait.php
359	Each PHP statement must be on a line by itself
src/Plugin/ImageToolkit/Operation/gd/Mask.php
33	The array declaration line has 107 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageToolkit/Operation/gd/TextToWrapper.php
108	The array declaration line has 98 characters (the limit is 80). The array content should be split up over multiple lines
186	The array declaration line has 144 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageToolkit/Operation/gd/Watermark.php
32	The array declaration line has 122 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageToolkit/Operation/imagemagick/TextToWrapper.php
41	The array declaration line has 100 characters (the limit is 80). The array content should be split up over multiple lines
src/Plugin/ImageToolkit/Operation/InterlaceTrait.php
28	The array declaration line has 82 characters (the limit is 80). The array content should be split up over multiple lines
tests/src/Functional/Effect/AspectSwitcherTest.php
54	The array declaration line has 84 characters (the limit is 80). The array content should be split up over multiple lines
tests/src/Functional/Effect/AutoOrientTest.php
18	The array declaration line has 84 characters (the limit is 80). The array content should be split up over multiple lines
tests/src/Functional/Effect/BackgroundTest.php
76	The array declaration line has 89 characters (the limit is 80). The array content should be split up over multiple lines
tests/src/Functional/Effect/ConvolutionTest.php
117	The array declaration line has 97 characters (the limit is 80). The array content should be split up over multiple lines
117	The array declaration line has 97 characters (the limit is 80). The array content should be split up over multiple lines
117	The array declaration line has 97 characters (the limit is 80). The array content should be split up over multiple lines
117	The array declaration line has 97 characters (the limit is 80). The array content should be split up over multiple lines
tests/src/Functional/Effect/GaussianBlurTest.php
48	The array declaration line has 90 characters (the limit is 80). The array content should be split up over multiple lines
tests/src/Functional/Effect/ScaleAndSmartCropTest.php
53	The array declaration line has 81 characters (the limit is 80). The array content should be split up over multiple lines

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3184864-2.patch26.53 KBPooja Ganjage

Comments

mondrake created an issue. See original summary.

Pooja Ganjage’s picture

StatusFileSize
new26.53 KB

Hi,

Creating a patch for this issue.

Please review the patch.

Let me know if any suggestions.

Thanks.

Pooja Ganjage’s picture

Status: Active » Needs review
mondrake’s picture

Status: Needs review » Postponed

Thank you. Well, now that I see this I am not very comfortable... that seems to get readibility worse rather than better, honestly.

Also see #3185082: Drupal.Arrays.Array.LongLineDeclaration make me write less readable code.

mondrake’s picture

Status: Postponed » Closed (won't fix)