The regions Higlighted and Preface top are missing in danland.info.yml. Why? Is this by design?
Due to that the website mission and website slogan cannot be shown anymore when Slideshow is enabled.
I had to add those regions again to make the mission and slogan visible again.

CommentFileSizeAuthor
#5 regions-after-patch.png32.58 KBindrajithkb
#5 regions-before-patch.png29.72 KBindrajithkb
#3 3184288-3.patch390 bytesbhumikavarshney

Comments

redseujac created an issue. See original summary.

redseujac’s picture

redseujac
he/him/his
Primary language Dutch
Location Ieper, BE 🇧🇪
commented
Issue summary: View changes
bhumikavarshney’s picture

bhumikavarshney commented
Status: Active » Needs review
StatusFileSize
new 3184288-3.patch390 bytes

Added patch with updated Regions.

vikashsoni’s picture

vikashsoni commented

@BhumikaVarshney thanks for the patch apply successfully

indrajithkb’s picture

indrajithkb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new regions-before-patch.png29.72 KB
new regions-after-patch.png32.58 KB

Hi @BhumikaVarshney thanks for the patch, it's applied and worked as expected.

Attaching screenshots for reference.

Before patch

image

After patch:

image

Moving to RTBC

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Comparing the regions with the code, nowhere are the page_top and page_bottom regions used. These should probably be removed from the danland.info.yml file.

I agree that the highlighted and preface regions are missing and should be added as they form part of the code in the templates/page.html.twig file. In addition, the slideshow region should be added.

These last were all removed in issue #3124087: Remove unused regions., which needs to be reverted, as it seems that issue was an error that now needs to be corrected.

jcnventura’s picture

jcnventura
Primary language English
commented
Related issues: +#3124087: Remove unused regions.

  • jcnventura committed c164d6a on 8.x-1.x 
    Issue #3184288 by BhumikaVarshney, Indrajith KB, jcnventura: Regions...
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.