CommentFileSizeAuthor
#6 unused-regions-3124087-6.patch444 byteskunal_kapoor
#4 3124087-4.patch607 bytesneslee canil pinto
#3 Screen Shot 2020-04-05 at 10.40.19 PM.png14.87 KBdjsagar
#2 unused_regions_issue-3124087-2.patch669 byteskunal_kapoor
Screen Shot 2020-04-01 at 5.16.13 PM.png64.23 KBdjsagar
screencapture-contrib-lndo-site-admin-structure-block-2020-04-01-17_16_25.png363.99 KBdjsagar

Comments

djsagar created an issue. See original summary.

kunal_kapoor’s picture

kunal_kapoor commented
Status: Active » Needs review
StatusFileSize
new unused_regions_issue-3124087-2.patch669 bytes

I have added a patch for this please let me know if it works.

djsagar’s picture

djsagar commented
Status: Needs review » Needs work
StatusFileSize
new Screen Shot 2020-04-05 at 10.40.19 PM.png14.87 KB

Hi @kunalkapoor,

Patch is not applied please rework for this issue.

Thanks!

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3124087-4.patch607 bytes
kunal_kapoor’s picture

kunal_kapoor commented
Status: Needs review » Needs work

The patch above is not working, please review the issue.

kunal_kapoor’s picture

kunal_kapoor commented
Status: Needs work » Needs review
StatusFileSize
new unused-regions-3124087-6.patch444 bytes

I have added a patch for this issue, please let me know if it works.

djsagar’s picture

djsagar commented
Status: Needs review » Reviewed & tested by the community

Patch no #6 is applied successfully

Thanks

  • kunalkapoor committed 8d661e5 on 8.x-1.x 
    Issue #3124087 by kunalkapoor, Neslee Canil Pinto, djsagar: Remove...
kunal_kapoor’s picture

kunal_kapoor commented
Status: Reviewed & tested by the community » Fixed
kunal_kapoor’s picture

kunal_kapoor commented
Status: Fixed » Closed (fixed)
redseujac’s picture

redseujac
he/him/his
Primary language Dutch
Location Ieper, BE 🇧🇪
commented

Why did you remove those regions? When slideshow is enabled they are necessary to show the website mission (region Highlighted) and the website slogan (preface top). I had to add those regions again.