Problem/Motivation

The settings and configuration from this theme are out of date and cleaning them up will improve maintainability and ease of use.

Changes I'm suggesting:

  • Adding a schema that captures the settings from this theme. Alternatively, we could try to emulate the much more complicated (but also more sophisticated) settings management that Bootstrap uses, which also updates sub-themes when updates to settings are released. But I don't understand how it works so for now, using Olivero as a model, we could just capture the settings in a schema file.
  • Removing respond.js configuration. This is not used anywhere and does nothing.
  • Remove the hard-coded Account Info settings. This adds stuff to the page template that is all duplicate functionality to the site info block and user menu blocks provided by core.

Remaining tasks/Issues to solve

  • Write patch
  • Test that this doesn't break existing sub-themes or hinder continued theme development.

Comments

sim_1 created an issue. See original summary.

sim_1’s picture

Title: Remove "Show Login/Signup information" configuration » Reorganize and clean up old settings and configuration
Issue summary: View changes

I'm updating the description and title to be more broad.

sim_1’s picture

Status: Active » Needs review
StatusFileSize
new7.53 KB

Ok, I'm hoping to get some other eyes on this and input on this patch. Does it apply cleanly? Does it break sub-themes? Does it remove the configuration it's trying to remove?

kclarkson’s picture

@sim_1

I attempted to apply this patch to the most recent Dev version and received the following error. Please note I am also running Drupal 9

Cannot apply patch Reorganize and clean up old settings and configuration (https://www.drupal.org/files/issues/2020-10-29/3179537-reogranize-config-3.patch)!

Changing back to needs work.

kclarkson’s picture

Status: Needs review » Needs work

Patch failed, on most recent dev.

suresh prabhu parkala’s picture

Status: Needs work » Needs review
StatusFileSize
new7.63 KB

Re-roll against the latest dev.

sim_1’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the re-roll! Marking as RTBC

  • sim_1 committed 065aa5e on 8.x-6.x
    Issue #3179537 by sim_1, Suresh Prabhu Parkala, kclarkson: Reorganize...
sim_1’s picture

Status: Reviewed & tested by the community » Fixed

Marking as fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

anybody’s picture

Testing with https://www.drupal.org/project/config_inspector I just found several left schema issues and opened a follow-up for that:
#3305456: Fix left schema issues