Problem/Motivation
Follow-up on #3179537: Reorganize and clean up old settings and configuration
Using https://www.drupal.org/project/config_inspector to test the configuration shows several open config schema errors. I just checked #3179537: Reorganize and clean up old settings and configuration and you can see in the commit, that there are still mistakes.
For example, instead of TRUE / FALSE for boolean values, they are set as 0 / 1 in the settings.
Furthermore, I think it might need a cleanup for existing pages to remove old config values that are no longer used.
Here are some examples from our project with zurb_foundation as base theme:
- features.favicon Shortcut icon boolean 1 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- features.node_user_picture User pictures in posts boolean 1 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- settings Undefined undefined missing schema
- logo.use_default Use default boolean 1 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- favicon.use_default Use the default shortcut icon supplied by the theme boolean 1 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_status_in_reveal Display status messages in Reveal boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_use_respondjs Undefined undefined 0 missing schema
- zurb_foundation_meta_header_grid Contain Meta Header Region to Grid boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_top_bar_enable Enable the top bar element integer 1 variable type is string but applied schema class is Drupal\Core\TypedData\Plugin\DataType\IntegerData
- zurb_foundation_top_bar_grid Contain the top bar to grid boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_top_bar_sticky Make the top bar sticky boolean 1 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_top_bar_is_hover Hover to expand menu boolean 1 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_top_bar_custom_back_text Enable custom back text in dropdown boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_top_bar_search Add search to top bar boolean 1 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_top_bar_languageswitcher Add language switcher to top bar boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_page_site_name Undefined undefined 0 missing schema
- zurb_foundation_page_site_logo Undefined undefined 1 missing schema
- zurb_foundation_page_account_info Undefined undefined 0 missing schema
- zurb_foundation_disable_base_css Disable Base Theme CSS boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_disable_base_js Disable Base Theme JavaScript boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_block_copyright_show Display custom copyright block boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
- zurb_foundation_block_copyright_custom_text Set custom copyright block text boolean 0 variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
Steps to reproduce
- Install & enable zurb_foundation theme
- Install & enable https://www.drupal.org/project/config_inspector
- See the config_inspector report "Errors only"
- Additionally review the config after saving the zurb_foundation settings form, as it may change the configuration. The results of the form save should also be checked, not just the initial configuration
Proposed resolution
- Fix the left config issues
- Does anyone know if there are tests possible to check for such issues?
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork zurb_foundation-3305456
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
anybodyPlease review and test as written above to see, if this fixes all or at least some of the issues.