The business rules module contains a sub-module, Business Rules - SMS Framework Integration (br_sms), whose modules/br_sms/br_sms.info.yml declares a dependency on sms:sms
Problem is, https://www.drupal.org/project/sms is a project placeholder (with an empty repository) for the https://www.drupal.org/project/smsframework project - although the first module declared in smsframework has the machine name sms, so sites that already had the smsframework project installed would already have a module named sms, and would continue to work (meaning it would be difficult to notice this problem).
I believe this is causing the Composer require-dev failure messages that happen when Testbot tries to run automated tests for this module.
modules/br_sms/br_sms.info.yml needs to be changed to depend on smsframework:sms instead.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3133400-2--smsframework-namespace-wrong.patch | 596 bytes | mparker17 |
Comments
Comment #2
mparker17Here's a patch. Existing tests already appear to be catching the problem, so I didn't add any to this patch.
Comment #3
mparker17Hmm... I wonder if, because Composer is used to download and install dependencies, Composer's list of dependencies are cached for the branch? If so, we won't know until it merges.
Reviews welcome nonetheless.
Comment #5
colanLet's see what the testbot says.
Comment #6
colanBranch is now passing so all good here. Thanks!