Allow to alter settings to add settings per entity bundle [#3168732]

Problem/Motivation

Currently it's only possible to configure "CHECKBOXES DEFAULT VALUE", "DISABLE CHECKBOXES" and "HIDE CHECKBOXES" settings per entity type.
It would be great to have an ability to configure these settings per entity bundle as well.

Steps to reproduce

I can't unset "CHECKBOXES DEFAULT VALUE" for some entity bundles, I can only do it for the whole entity type.

Proposed resolution

In first comment I'm attaching the patch that adds `hook_entity_clone_settings_alter` hook where users can alter form settings and add settings per bundle.

function hook_entity_clone_settings_alter(array &$form_settings) {
  // Adding settings per entity bundle.
  $form_settings['taxonomy_term']['vocabulary_name']['default_value'] = false;
  $form_settings['taxonomy_term']['vocabulary_name']['disable'] = false;
  $form_settings['taxonomy_term']['vocabulary_name']['hidden'] = false;
}

Data model changes

Entity Clone Form settings array can now have settings per bundle if user add it in alter hook.

Comment	File	Size	Author
#20	Capture d’écran 2025-04-10 à 00.52.45.png	244.4 KB	mably
#19	Capture d’écran 2025-04-10 à 00.30.24.png	114.54 KB	mably
#17	entity_clone-settings_per_bundle-3168732-MR96-17.patch	13.58 KB	mably
#12	entity_clone-settings_per_bundle-3168732-12.patch	8.46 KB	dpiet
#2	entity_clone-settings_per_bundle-3168732-2.patch	7.56 KB	skdrupal88

Issue fork entity_clone-3168732

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3168732-handle-entity-bundles changes, plain diff MR !96
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

3168732-allow-to-alter

changes, plain diff MR !38

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

2 September 2020 at 15:00

skorzh created an issue. See original summary.

Comment #2

skdrupal88

Russian

Belarus

commented 2 September 2020 at 15:02

Status:

Active

» Needs review

Status	File	Size
new	entity_clone-settings_per_bundle-3168732-2.patch	7.56 KB

Attaching the patch that adds `hook_entity_clone_settings_alter` hook where users can alter form settings and add settings per bundle.

function hook_entity_clone_settings_alter(array &$form_settings) {
  // Adding settings per entity bundle.
  $form_settings['taxonomy_term']['vocabulary_name']['default_value'] = false;
  $form_settings['taxonomy_term']['vocabulary_name']['disable'] = false;
  $form_settings['taxonomy_term']['vocabulary_name']['hidden'] = false;
}

Comment #3

11 April 2021 at 17:22

DieterHolvoet made their first commit to this issue’s fork.

Comment #4

dieterholvoet commented 11 April 2021 at 17:24

Created a merge request and rebased against #df77f98.

Comment #5

12 March 2023 at 20:53

DieterHolvoet opened merge request !38

Comment #6

dieterholvoet commented 12 March 2023 at 20:55

Version:

8.x-1.x-dev

» 2.x-dev

Comment #7

25 March 2023 at 09:06

Rajeshreeputra made their first commit to this issue’s fork.

Comment #8

dieterholvoet commented 9 July 2023 at 13:08

Comment #9

25 July 2024 at 09:05

beloglazov91 made their first commit to this issue’s fork.

Comment #10

rajeshreeputra

he/him

Pune

commented 28 July 2024 at 11:42

This looks good, can we get it RTBC.

Comment #11

mably commented 9 April 2025 at 09:50

Status:

Needs review

» Reviewed & tested by the community

Works fine. Should get merged.

Comment #12

dpiet commented 9 April 2025 at 09:54

Status	File	Size
new	entity_clone-settings_per_bundle-3168732-12.patch	8.46 KB

Updated patch in order to use in composer.json, tested successfully on Drupal 11.1.5.

Comment #13

mably commented 9 April 2025 at 12:05

Just wondering why the && $is_cloneable conditions have been removed.

An idea anyone?

Comment #14

mably commented 9 April 2025 at 13:33

Status:

Reviewed & tested by the community

» Needs work

In fact, doesn't seem to work if the checkbox are hidden, investigating.

Comment #15

9 April 2025 at 17:07

mably opened merge request !96

Comment #16

mably commented 9 April 2025 at 18:05

Status:

Needs work

» Reviewed & tested by the community

New MR 96 works fine.

Handles multiple target bundles and reintroduce the is_cloneable test.

Works even if all checkboxes are hidden.

Removed failing test incompatible with Drupal 11, all tests are green now.

RTBC.

Comment #17

mably commented 9 April 2025 at 18:08

Status	File	Size
new	entity_clone-settings_per_bundle-3168732-MR96-17.patch	13.58 KB

Comment #18

mably commented 9 April 2025 at 21:31

Status:

Reviewed & tested by the community

» Needs work

Definitely not the best way to handle bundle value. Working on it.

Comment #19

mably commented 9 April 2025 at 22:33

Status	File	Size
new	Capture d’écran 2025-04-10 à 00.30.24.png	114.54 KB

We finally decided to simply display all the bundles on the configuration screen instead of using a hook:

Bundles

What do you think?

Comment #20

mably commented 9 April 2025 at 22:54

Status	File	Size
new	Capture d’écran 2025-04-10 à 00.52.45.png	244.4 KB

A new configuration option has been added, allowing to enable/disable the bundles feature at will:

Bundles toggler

Comment #21

mably commented 10 April 2025 at 08:49

Status:

Needs work

» Needs review

Comment #22

mably commented 21 May 2025 at 10:08

FYI it has been successfully deployed on a high traffic website (bordeaux.fr) for several weeks without any problem.

Comment #23

1 September 2025 at 10:21

deaom made their first commit to this issue’s fork.

Comment #24

deaom commented 1 September 2025 at 10:25

Added a check as when you first save the settings, the form_settings are empty/null, so array_merge returns an error, as the first element is null (TypeError: array_merge(): Argument #1 must be of type array, null given in array_merge() (line 119 of /contrib/entity_clone/src/EntityCloneSettingsManager.php).) and thus preventing the settings form to be saved.
After the first save, the form_settings is populated.
This can be tested by installing the module and saving the settings, or if the module is already installed first uninstalling it and then installing again and saving the settings.
Leaving to Needs review, but based on the comments can be merged.

Needs review

» Reviewed & tested by the community

Patch has been deployed in production for several months now. Everything is still running fine.

Comment #29

rajeshreeputra

he/him

Pune

commented 6 September 2025 at 04:32

Started merge train.

Comment #30

6 September 2025 at 04:36

rajeshreeputra committed ec33469d on 2.x authored by mably

Issue #3168732 by dieterholvoet, beloglazov91, mably, skorzh,...

Comment #31

rajeshreeputra

he/him

Pune

commented 6 September 2025 at 04:48

Status:

Reviewed & tested by the community

» Fixed

Comment #32

6 September 2025 at 04:48

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Comment #33

20 September 2025 at 04:49

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.