not working in d9

CommentFileSizeAuthor
#7 drupal-9-update-3166681-7.patch3.5 KBjez500
#2 Screenshot 2020-11-01 at 15.41.11.png31.13 KBgauravvvv
#2 D9-READY-3166681-2.patch290 bytesgauravvvv

Issue fork nodejs-3166681

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

webberly created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new D9-READY-3166681-2.patch290 bytes
new Screenshot 2020-11-01 at 15.41.11.png31.13 KB

I have provided a patch please verify if it is working or not. Adding a after patch screenshot for reference.

uniquename made their first commit to this issue’s fork.

uniquename opened merge request !1

imclean’s picture

imclean commented
Title: not working in d9 » Drupal 9 compatibility
imclean’s picture

imclean commented
Status: Needs review » Reviewed & tested by the community

These changes allow the modules to be enabled in Drupal 9.

jez500’s picture

jez500 commented
StatusFileSize
new drupal-9-update-3166681-7.patch3.5 KB

#2 Only addresses the main nodejs module but there are a number of sub modules: ajax, config, notify, watchdog

This patch addresses all of the nodejs_* modules. Tested all modules with 9.2 and all enable + function as advertised

imclean’s picture

imclean commented
Status: Reviewed & tested by the community » Needs review
imclean’s picture

imclean commented

The MR in #4 addresses all the modules.

imclean’s picture

imclean commented
Status: Needs review » Reviewed & tested by the community
imclean’s picture

imclean commented
Related issues: +#3237094: Offering to maintain Node.js integration

le72’s picture

le72
Location Yerevan 🇦🇲
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.