Problem/Motivation

------ ----------------------------------------------------------------
Line src/Tests/FieldTokensTestBase.php
------ ----------------------------------------------------------------
10 Class Drupal\field_tokens\Tests\FieldTokensTestBase extends
deprecated class Drupal\image\Tests\ImageFieldTestBase:
in drupal:8.9.3 and is removed from drupal:9.0.0.
Use \Drupal\Tests\image\Functional\ImageFieldTestBase instead.
37 Call to method setUp() of deprecated class
Drupal\image\Tests\ImageFieldTestBase:
in drupal:8.9.3 and is removed from drupal:9.0.0.
Use \Drupal\Tests\image\Functional\ImageFieldTestBase instead.
------ ----------------------------------------------------------------

[ERROR] Found 2 errors

CommentFileSizeAuthor
#12 3165349-12.patch752 bytesmahtab_alam
#8 dist_d9_compatibility-3165349-8.patch847 bytesweekbeforenext
#8 interdiff_5-8.txt313 bytesweekbeforenext
#8 d9_compatibility-3165349-8.patch751 bytesweekbeforenext
#5 d9_compatibility-3165349-5.patch731 bytesvinay15

Issue fork field_tokens-3165349

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Vinay15 created an issue. See original summary.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Issue summary: View changes
vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Issue summary: View changes
vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Issue summary: View changes
vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Assigned: vinay15 » Unassigned
Status: Active » Needs review
StatusFileSize
new d9_compatibility-3165349-5.patch731 bytes
mattlt’s picture

mattlt
he/him/they/them
Primary language English
Location Freeport, MN
commented
Status: Needs review » Reviewed & tested by the community

This also includes half the patch from https://www.drupal.org/project/field_tokens/issues/3003269 . It prefixes the dependency but doesn't capitalize the module name.

Thanks,

•• matt

arthur.baghdasar’s picture

arthur.baghdasar commented

Is this going to be released some day?

weekbeforenext’s picture

weekbeforenext
Primary language English
Location Asheville, NC
commented
StatusFileSize
new d9_compatibility-3165349-8.patch751 bytes
new interdiff_5-8.txt313 bytes
new dist_d9_compatibility-3165349-8.patch847 bytes

Re-rolled the patch to include the title capitalization change. I know this is incredibly minor, but I needed a different patch and thought I'd include it while I was here.

Also created a patch that can be applied to the beta1 version of the module if it's installed via composer with the "preferred-install" config set to "dist". The "dist" prefixed patch is a bandaid until the main patch merges.

This describes the issue and why a separate patch is needed: https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa....

bestller made their first commit to this issue’s fork.

bestller opened merge request !1

natts’s picture

natts
He/they
Primary language English
Location London
commented
Status: Reviewed & tested by the community » Needs work

This commit should be released urgently. Drupal 8 is now End Of Life, and so Drupal 9 compatibility is urgently required in a stable release.

mahtab_alam’s picture

mahtab_alam commented
StatusFileSize
new 3165349-12.patch752 bytes
mahtab_alam’s picture

mahtab_alam commented
Status: Needs work » Needs review
natts’s picture

natts
He/they
Primary language English
Location London
commented

I've become a maintainer of this module, and have approved the merge request in #10 and included it in a new release: https://www.drupal.org/project/field_tokens/releases/2.0.0-rc1

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Version: 8.x-1.x-dev » 2.0.0-rc1
Status: Needs review » Fixed

I believe that we can close this now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.