Meeting of the Bug Smash Initiative 2020-08-04 [#3160937]

Agenda items

Standing items

Who is here
Any other suggested topics
Wins / Thanks / Frustrations
Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
The bug I would most like to see fixed
Update on action items from last meeting
What should be the initiative focus for the next 2 weeks?

New items

@todo

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

pratik_kamble	Pratik Kamble, Pune India
Ridhima Abrol	Ridhima Abrol, India
jungle	Jungle, Chongqing, China
kimb0	Kim Pepper, Australia
dww	Derek, US, Black Lives Matter
pameeela	Pam, AU
Kristen Pol (she/her)	Kristen, CA, USA
acbramley	Adam Bramley, Melbs
quietone	Vicki, NZ
Griffyn Heels	Griff, Melbourne, Aus :mask:
larowlan	Lee au
sime	Simon, AU
Michael (g-brodiei)	Michael, Taiwan
lendude	Len, Amsterdam
samiullah	samiullah, India
partyka	Jason, Illinois, USA
jonathanjfshaw	Jonathan, UK

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

pameeela	Potential aim for the initiative: triage the RTBC queue to make sure what's there is actually RTBC. Committers are finding things there that aren't ready and this becomes very time consuming for them.
dww	Anyone want to improve our initiative page? Flesh out more of the @todo sections?
samiullah	Limit the automated tests based on version code is supported for
dww	Sadly, now that the meeting is officially over, this thread is no longer going to result in new threads for the "meeting". In the future, if you have ideas you want to discuss and you can't be there, please add them to the issue for the next meeting. You can always find a link to the next meeting's issue at #3153713: Bug Smash Initiative meetings - next: 2025-12-09@samiullah: For now, you might as well just start your own (non-meeting) thread in the channel to discuss this. (edited)
samiullah	sure @dww Thanks

2️⃣ .1️⃣ Wins - what wins have you had this fortnight - share your successes!

acbramley	Revision author for Media/Block Content is now available in views :slightly_smiling_face: #3131126: Can't show 'revision author' on Block content views
Kristen Pol (she/her)	I think 6 issues I helped on were committed yesterday! Smash smash smash :)
quietone	Moved all issues out of simpletest.module component
samiullah	Tested lot of issues, some of them moved to RTBC, waiting for them to get moved to Fixed :slightly_smiling_face:
dww	Oh right, I forgot these happened since the last meeting! Very happy about:https://www.drupal.org/node/1393226https://www.drupal.org/node/3161070
partyka	#3074201: Drupal\Core\Routing\RouteCompiler::compile($route) assumes that the '$route' object is injected.

2️⃣ .:two: Thanks - a space for callouts to other contributors who’ve helped you this fortnight

pameeela	@Kristen Pol (she/her) shoutout for absolutely smashing the queue!
Kristen Pol (she/her)	Thanks! I was inspired by @pameeela :)
dww	Thanks also to @Kristen Pol (she/her) for suggesting some good fixes to the issue queues and reviewing my patches for them:#3162889: Provide a magic '- Closed issues -' status for issue queue views
Kristen Pol (she/her)	Big thanks to @dww for making patches so quickly!!!
partyka	Thanks to @longwave for reviews on 3074201

2️⃣ .3️⃣ Frustrations - what’s been a source of frustration this fortnight - a space to vent

dww	I'm happy to see this thread tends to be empty in our meetings. :heart: I once heard a very wise perspective that "there's no such thing as 'venting', you're just rehearsing" -- rehashing your negative emotions about something and reliving the frustration. Maybe we could remove this as a standard agenda item going forward?
pratik_kamble	I sometime feel one thread should be there to listen to pain points of contributor. May be we can rephrase this these item. @larowlan any thoughts
larowlan	But the acronym
dww	What acronym?
larowlan	2.1, 2.2, 2.3 wins, thanks, frustrations :joy:
larowlan	always thinking about these things when naming … see also drupal.org/project/field_union
larowlan	i’ll see myself out
larowlan	but yeah +1 to remove frustrations - jokes aside
samiullah	from testers point of view, steps to replicate were missing in some issues. We shd make it a practice to add issue replication steps
dww	@samiullah It should hopefully be getting a bit better now that https://www.drupal.org/node/1393226 and #2281761: Add "Steps to reproduce" section to "Bare issue summary template" for dreditor and default value for new issues are done/deployed.
samiullah	thanks @dww looks good.
xjm	WRT whether we should include a frustrations/blockers thread, maybe we could rephrase it to be something like "Barriers"?
dww	So long as we don't call them "Obstacles" (for the acronym inclined). :wink:

3️⃣ Core bug statistics - current state of open bugs

Griffyn Heels

67 resolved57 created10 tickets in the green!

4️⃣ Bug I’d most like to see fixed

quietone	#2678510: Remove @todos from migrate credentials form
dww	This one has been annoying recently: #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof
dww	I hope to have time to keep working on #1538118: Update status does not verify the identity or authenticity of the release history URL this week, too. That's been open WAY too long. :(
larowlan	#2906919: Allow users to create a block content entity with a specific UUID if it is a missing dependency of a config object
Kristen Pol (she/her)	This issue has been dragging on for a long time and would be great to smash: #1521996: Password reset form reveals whether an email or username is in use

5️⃣ Highlights from the last meeting

Griffyn Heels

Here's the highlights from last meeting:

Griffyn Heels

Focuses for this fortnight - https://drupal.slack.com/archives/C014QES6HSQ/p1595304184384000No confirmed mentor for this fortnightTooltip text still TBCHow to get more feedback on my issues: https://drupal.slack.com/archives/C014QES6HSQ/p1595304762392200Establishing a policy for closing bug reports for updates to versions no longer supported?: https://drupal.slack.com/archives/C014QES6HSQ/p1595304860394800When to use the #bugsmash tag: https://drupal.slack.com/archives/C014QES6HSQ/p1595305019398800 (edited)

6️⃣ Suggest a focus for the next two weeks in this thread. Vote on the suggestions you like. We’ll pick the one with the most votes in 24 hours and use that as our focus until the next meeting

Kristen Pol (she/her)	I'm curious how many people focus on the focus. TBH, I just look for any bug that needs review
dww	Yeah, after a few weeks, I'm becoming less and less convinced that this is meaningful or worth spending time discussing. Focusers gonna focus. Everyone else gonna do whatever comes across their radar. :wink:
pameeela	yeah, i find it's not that i don't agree with the focus or anything like that, but if it's not something i can help with i will just get on with the stuff i can do.
pameeela	it is hard enough to find anything useful to do, without having to narrow the focus!
dww	Yeah, I think the "focus" has been mostly "insiders" working on stuff we'd already be working on. ;)
quietone	Or, the focus isn't promoted or perhaps it needs someone to lead it.

7️⃣ Who is going to be the mentor for this coming fortnight?

Griffyn Heels	I think we retire this fortnightly question. It wasn't too popular last time either.
Griffyn Heels	As a community we can help newbies/each other in the right direction.

8️⃣ From @pameeela "Potential aim for the initiative: triage the RTBC queue to make sure what's there is actually RTBC. Committers are finding things there that aren't ready and this becomes very time consuming for them."

dww	I sometimes feel crappy trolling the RTBC queue with pedantic reviews, but it's definitely a win. Every time a committer opens and RTBC issue and has to move it back to NW is another RTBC issue they didn't have time to fix.
dww	"We" should definitely give committers every possible reason to commit something if it's going to be sitting at RTBC.
pameeela	i think there is a fair bit getting through that is even more obvious, like needs tests or doesn't incorporate previous maintainer/committer feedback.
pameeela	pedantic reviews are OK too though, if you have the time and the feedback.
Kristen Pol (she/her)	Maybe we can make it clear we're double checking the RTBC for bugsmash? To address tge issue that it may look to others like redundant work? (edited)
pameeela	i didn't mean to check only for bugsmash, i just meant in general
pameeela	but if you check an issue and have no feedback, i'd say just leave it, if you have feedback then it's not redundant!
pratik_kamble	Probably setting up some comment template for RTBC will help (edited)
pameeela	hmm, i think by the time it's RTBC it needs a custom message if it's getting bumped
dww	Yeah, I think we should always review issues as if we were core committers. The more we get things in shape before a core committers spends time on it, the better.
jungle	I have been doing so -- checking RTBC’d issues. looking for what could be improved before committers jumping in. CS violations, documentation improvements, micro optimizations etc.
dww	But especially once they're at RTBC, we should make sure they belong there.
dww	Also making sure the summary / title are accurate.
Kristen Pol (she/her)	If we check it and it looks good but we don't leave a comment then someone else may double check it as well which duplicates work
pratik_kamble	Probably we can add it as document for steps which @jungle follows. To avoid going back and forth of issue queue
Kristen Pol (she/her)	It would be good to have a checklist
Kristen Pol (she/her)	I have a mental checklist but not an easy reference
pameeela	If we check it and it looks good but we don't leave a comment then someone else may double check it as well which duplicates worki'm not sure i agree, just because i didn't spot something doesn't mean someone else wouldn't? (edited)
jungle	If we check it and it looks good but we don’t leave a comment then someone else may double check it as well which duplicates workit’s fine, to me, everyone could find something to improve probably. but a generic checklist would help.
dww	https://www.drupal.org/community-initiatives/drupal-core/bug-smash#review links to some handbook pages about doing good reviews.
dww	The patch review page is pretty good, but perhaps could use an explicit "Steps to check before something is RTBC" list.
jungle	http://xjmdrupal.org/review-guide#checklist
jungle	See xjm's patch review checklist.
dww	Right, but that's 3 clicks removed from the Bug Smash page. ;) I think we could put some of the x j m list directly on the '/patch/review' page.
Kristen Pol (she/her)	For me, bullets with as few words as possible is the best1. Title makes sense 2. Issue summary is complete and relevant3. Tests pass4. Patch for latest version5. Code reviewed6. New tests added if relevant7. Tagged appropriatelyEtc (edited)
dww	That looks like a great start. https://www.drupal.org/node/772/edit anyone? :wink:
dww	(yes, that page really is a 3 digit nid!)
dww	For now, I added a link to https://www.drupal.org/project/issues/search/drupal?status%5B%5D=14&cate... to the Needing triage (from developers) section. (edited)

9️⃣ from @dww "Anyone want to improve our initiative page? Flesh out more of the @todo sections?"

dww	Thanks to @pameeela for giving it the nice artwork. ;) But other than that, I've done like 90% of the revisions at https://www.drupal.org/node/3150111/revisions -- would love for some other folks to dive in.
Griffyn Heels	Love the artwork!
quietone	Can you provide specific examples of what needs to be done?
dww	A) the @todo comments ;)
dww	B) I think "How to help" section needs help.
Kristen Pol (she/her)	Very meta
dww	Although looking again, it's definitely not as skeletal as I remember. So it has been improving. Thanks also @quietone! I hadn't seen your edits.
quietone	Haha. I mean what do you envision that the 'todos' are replaced with. Links to more existing pages?
dww	Yeah, generally I think linking to existing docs is better than writing new content directly in this page.
quietone	That helps. I will make another attempt this fortnight.
dww	But the d.o handbook universe is vast, an stuff can be spread out into multiple sections / areas. So I think we can do a useful service by collecting links from disparate places and having a nice pile in one spot for easy finding.

1️⃣ 0️⃣ Okay team, Bugsmash meeting 5 is over. Thanks all for coming! Please feel free to keep chatting in the threads.

Kristen Pol (she/her)	Thanks for leading
Griffyn Heels	Thanks @pratik_kamble for coordinating!
larowlan	You rock :rockcat:
quietone	@pratik_kamble thank you!
kimb0	:boom:
samiullah	Thanks @pratik_kamble

Participants:

pratik_kamble, Ridhima Abrol, jungle, kimb0, dww, pameeela, Kristen Pol (she/her), acbramley, quietone, Griffyn Heels, larowlan, sime, Michael (g-brodiei), lendude, samiullah, partyka, jonathanjfshaw, xjm