Needs work
Project:
Claro
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Jul 2020 at 15:10 UTC
Updated:
21 Sep 2026 at 15:23 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
mayurjadhav commentedHi @bnjmnm
Yes we need to change this, Extra padding is added to the filter form action button on Locale translate filter form.
This is completely independent and removing padding will not make any impact on any other forms or action buttons.
Patch is ready with me, once we get the confirmation i'll update here.
Thanks.
Comment #3
kostyashupenkoNot sure, maybe best way here to not just extend original library, but carefully rewrite it from scratch (from Claro only)?
Comment #4
KondratievaS commentedTested patch from #3 for mobile and desktop resolutions in Chrome, FF, Safari and IE browsers. Result is OK
Comment #6
abhijith s commentedApplied the patch #3 on 9.2.x and it works fine.The whitespace is reduced after this patch.Adding screenshots below.
Before patch;

After patch:

Comment #8
sakthivel m commentedApplied the patch #3 on 9.3.x and it works fine.The whitespace is reduced after this patch. Adding screenshots below.
Moved to RTBC
Comment #9
sakthivel m commentedComment #10
lauriiiDid you try if unloading
core/modules/locale/css/locale.admin.csswould solve this? I checked the CSS and it seems like at least most of it isn't needed in Claro.Comment #11
phenaproximaI tried @lauriii's suggestion of removing locale.admin.css in Claro, and it had the desired effect:
Attaching a patch which takes this approach.
Comment #12
tim.plunkettGood suggestion @lauriii, indeed the core
locale.admin.csshas a lot of unnecessary code, and I don't see any visual regressions after unloading it, only the desired improvements.Comment #13
lauriiiIt seems like the patch from #11 failed CI.
Comment #14
phenaproximaLooks like it's passed now...?
Comment #16
bnjmnmAnother unrelated test failure switched this out of RTBC. Switching back
Comment #21
gauravvvv commentedRe-rolled Patch #11, as it's no longer applies to 10.1.x.
Comment #22
ameymudras commentedIve tested the patch on 10.1.x and following are my findings
1. The Issues summary is clear and explains the problem
2. Was able to replicate the problem
3. The patch applies cleanly
4. The patch fixes the issue and eliminates the extra space.
5. Did a code review and its a simple change to offload the locale.admin.css css as per #10
Moving the issue to RTBC, skipping before / after screenshots, since a few have been already provided
Comment #23
lauriiiI am not sure we should actually get rid of this CSS file completely. The file seems to contain several UX enhancements to the translation related UIs. They may seem minor but I assume some thought has been put behind them.
Comment #26
gauravvvv commentedThe updated solution as per #23 no longer removes the locale.admin.css file. Instead, it adds `
padding-block-start: 0;` for the button. Please reviewComment #27
divya.sejekan commentedVerified for both D10 and D11 . The fix looks fine.
Verified using MR - 3159892-filter-button-in
Testing steps :
1. Enable language module
2. Navigate to /admin/config/regional/translate
3. Check the filter button
RTBC ++
Keeping in Review state for further review
Comment #28
kanchan bhogade commentedHi
Tested MR !7841 on Drupal 11
MR is applied Cleanly...
Test Result:
The Filter Button extra whitespace reduced and it looks good now.
RTBC+1
Adding screenshots for reference
Comment #29
smustgrave commentedLooking just at the issue summary
= can it be pointed out where the agreement was
= same
= was this done? Definitely don't see
= related to above
Comment #31
quietone commentedThe Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.
Comment #32
smustgrave commentedClaro has moved to contrib