Problem/Motivation

Currently there are two PHP fatals when trying to access the Google Analytics Reports API settings form:

TypeError: Argument 1 passed to Drupal\google_analytics_reports_api\Form\GoogleAnalyticsReportsApiAdminSettingsForm::__construct() must be an instance of Drupal\google_analytics_reports_api\Form\ConfigFactoryInterface, instance of Drupal\Core\Config\ConfigFactory given

TypeError: Argument 3 passed to Drupal\google_analytics_reports_api\Form\GoogleAnalyticsReportsApiAdminSettingsForm::__construct() must be an instance of Drupal\google_analytics_reports_api\Form\RequestStack, instance of Symfony\Component\HttpFoundation\RequestStack given

Proposed resolution

  • Add missing use statements for items named in PHP fatal errors

Remaining tasks

  • Provide a patch

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Release notes snippet

Add missing use statements for GoogleAnalyticsReportsApiAdminSettingsForm

CommentFileSizeAuthor
#2 3159534-2.patch1005 byteshctom

Comments

hctom created an issue. See original summary.

hctom’s picture

Status: Active » Needs review
StatusFileSize
new1005 bytes

...and here is the proposed patch to fix this issue.

Status: Needs review » Needs work

The last submitted patch, 2: 3159534-2.patch, failed testing. View results

rajab natshah’s picture

Thanks Tom for reporting and patching!!
This is a quick fix and a quick fix release will follow

  • RajabNatshah committed 4d7acd8 on 8.x-3.x authored by hctom
    Issue #3159534 by hctom: Add missing use statements for...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Status: Needs work » Needs review
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

hctom’s picture

Wow, thanx for fixing that so quickly! ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.