Problem/Motivation
Currently there are two PHP fatals when trying to access the Google Analytics Reports API settings form:
TypeError: Argument 1 passed to Drupal\google_analytics_reports_api\Form\GoogleAnalyticsReportsApiAdminSettingsForm::__construct() must be an instance of Drupal\google_analytics_reports_api\Form\ConfigFactoryInterface, instance of Drupal\Core\Config\ConfigFactory given
TypeError: Argument 3 passed to Drupal\google_analytics_reports_api\Form\GoogleAnalyticsReportsApiAdminSettingsForm::__construct() must be an instance of Drupal\google_analytics_reports_api\Form\RequestStack, instance of Symfony\Component\HttpFoundation\RequestStack given
Proposed resolution
- Add missing use statements for items named in PHP fatal errors
Remaining tasks
- Provide a patch
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Release notes snippet
Add missing use statements for GoogleAnalyticsReportsApiAdminSettingsForm
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3159534-2.patch | 1005 bytes | hctom |
Comments
Comment #2
hctom...and here is the proposed patch to fix this issue.
Comment #4
rajab natshahThanks Tom for reporting and patching!!
This is a quick fix and a quick fix release will follow
Comment #6
rajab natshahComment #7
rajab natshahComment #8
rajab natshahComment #9
rajab natshahReleased Google Analytics Reports 8.x-3.0-rc3
https://www.drupal.org/project/google_analytics_reports/releases/8.x-3.0...
Comment #10
hctomWow, thanx for fixing that so quickly! ;)