Automated Drupal 9 compatibility fixes

There are other issue on this module apart from the once autofixed by Rector

------ -----------------------------------------------------------------------
  Line   brightcove.install
 ------ -----------------------------------------------------------------------
  227    Call to deprecated method applyUpdates() of class
         Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface:
         in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface::getChange
         List()
         and execute each entity type and field storage update manually
         instead.
 ------ -----------------------------------------------------------------------

 ------ -----------------------------------------------------------------
  Line   brightcove.module
 ------ -----------------------------------------------------------------
  261    Call to deprecated function system_get_info():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal::service('extension.list.$type')->getExtensionInfo() or
         \Drupal::service('extension.list.$type')->getAllInstalledInfo()
         instead.
  357    Call to deprecated method getVocabularyId() of class
         Drupal\taxonomy\TermInterface:
         in drupal:8.?.? and is removed from drupal:9.0.0. Use
         TermInterface::bundle() instead.
 ------ -----------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------
  Line   modules/media_entity_brightcove/src/Plugin/MediaEntity/Type/BrightcoveVideo.php
 ------ ---------------------------------------------------------------------------------
         Class Drupal\media_entity\MediaTypeBase not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
  19     Class Drupal\media_entity\MediaTypeBase not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ ---------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------
  Line   src/BrightcovePlaylistListBuilder.php
 ------ ---------------------------------------------------------------------
  21     Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait in
         class Drupal\brightcove\BrightcovePlaylistListBuilder:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Link instead.
  106    Call to deprecated method l() of class
         Drupal\brightcove\BrightcovePlaylistListBuilder:
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\Link::fromTextAndUrl() instead.
 ------ ---------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/BrightcoveUtil.php
 ------ ----------------------------------------------------------------------
  199    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  209    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  215    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  220    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ---------------------------------------------------------------------
  Line   src/BrightcoveVideoListBuilder.php
 ------ ---------------------------------------------------------------------
  23     Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait in
         class Drupal\brightcove\BrightcoveVideoListBuilder:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Link instead.
  111    Call to deprecated method l() of class
         Drupal\brightcove\BrightcoveVideoListBuilder:
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\Link::fromTextAndUrl() instead.
 ------ ---------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Controller/BrightcoveSubscriptionController.php
 ------ ----------------------------------------------------------------------
  208    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  251    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  283    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  303    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  306    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  325    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  328    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  395    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  398    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ---------------------------------------------------------------
  Line   src/Entity/BrightcoveTextTrack.php
 ------ ---------------------------------------------------------------
  271    Call to deprecated constant NODE_NOT_PUBLISHED: Deprecated in
         drupal:8.?.? and is removed from drupal:9.0.0. Use
         \Drupal\node\NodeInterface::NOT_PUBLISHED instead.
  271    Call to deprecated constant NODE_PUBLISHED: Deprecated in
         drupal:8.?.? and is removed from drupal:9.0.0. Use
         \Drupal\node\NodeInterface::PUBLISHED instead.
 ------ ---------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Entity/BrightcoveVideo.php
 ------ ----------------------------------------------------------------------
  172    Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in
         drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
  172    Call to deprecated constant FILE_MODIFY_PERMISSIONS: Deprecated in
         drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::MODIFY_PERMISSIONS.
  172    Call to deprecated function file_prepare_directory():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
  924    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  928    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ---------------------------------------------------------------
  Line   src/Entity/BrightcoveVideoPlaylistCmsEntity.php
 ------ ---------------------------------------------------------------
  80     Call to deprecated constant NODE_NOT_PUBLISHED: Deprecated in
         drupal:8.?.? and is removed from drupal:9.0.0. Use
         \Drupal\node\NodeInterface::NOT_PUBLISHED instead.
  80     Call to deprecated constant NODE_PUBLISHED: Deprecated in
         drupal:8.?.? and is removed from drupal:9.0.0. Use
         \Drupal\node\NodeInterface::PUBLISHED instead.
 ------ ---------------------------------------------------------------

 ------ -----------------------------------------------------------------
  Line   src/EventSubscriber/BrightcoveInitSubscriber.php
 ------ -----------------------------------------------------------------
  22     Call to deprecated function system_get_info():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal::service('extension.list.$type')->getExtensionInfo() or
         \Drupal::service('extension.list.$type')->getAllInstalledInfo()
         instead.
 ------ -----------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/BrightcoveAPIClientDeleteForm.php
 ------ ----------------------------------------------------------------------
  96     Parameter $query_factory of method
         Drupal\brightcove\Form\BrightcoveAPIClientDeleteForm::__construct()
         has typehint with deprecated class
         Drupal\Core\Entity\Query\QueryFactory:
         in drupal:8.3.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\Entity\EntityStorageInterface::getQuery() or
         \Drupal\Core\Entity\EntityStorageInterface::getAggregateQuery()
         instead.
  253    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ -----------------------------------------------------------------------
  Line   src/Form/BrightcoveAPIClientForm.php
 ------ -----------------------------------------------------------------------
  96     Parameter $query_factory of method
         Drupal\brightcove\Form\BrightcoveAPIClientForm::__construct() has
         typehint with deprecated class Drupal\Core\Entity\Query\QueryFactory:
         in drupal:8.3.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\Entity\EntityStorageInterface::getQuery() or
         \Drupal\Core\Entity\EntityStorageInterface::getAggregateQuery()
         instead.
  320    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  344    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  353    Call to deprecated method urlInfo() of class
         Drupal\Core\Entity\EntityInterface:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.
 ------ -----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/BrightcovePlaylistForm.php
 ------ ----------------------------------------------------------------------
  108    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  114    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  121    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/BrightcoveSubscriptionDeleteForm.php
 ------ ----------------------------------------------------------------------
  64     Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  79     Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  82     Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/BrightcoveSubscriptionForm.php
 ------ ----------------------------------------------------------------------
  98     Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  105    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  108    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/BrightcoveTextTrackForm.php
 ------ ----------------------------------------------------------------------
  33     Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  39     Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/BrightcoveVideoForm.php
 ------ ----------------------------------------------------------------------
  265    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  271    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  278    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ -----------------------------------------------------------------------
  Line   src/Form/BrightcoveVideoPlaylistForm.php
 ------ -----------------------------------------------------------------------
  34     Parameter $entity_manager of method
         Drupal\brightcove\Form\BrightcoveVideoPlaylistForm::__construct() has
         typehint with deprecated interface
         Drupal\Core\Entity\EntityManagerInterface:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
 ------ -----------------------------------------------------------------------

This patch adds a couple more compatibility fixes for D9. The only items remaining are:

In brightcove.install:122
Call to deprecated method applyUpdates() of class Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface. Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface::getChangeList() and execute each entity type and field storage update manually instead.

This install hook would not work as of Drupal 8.7 anyway.

In modules/media_entity_brightcove/src/Plugin/MediaEntity/Type/BrightcoveVideo.php
Class Drupal\media_entity\MediaTypeBase not found.

This module is deprecated and slated to be removed. It only works with Media Entity which likely won't have a Drupal 9 release: #3137216: Drupal 9 Compatibility

The new patch contains fixes for the calls to drush_print() and adds a core version requirement to the Media Brightcove module.

<!-- THEME DEBUG -->
<!-- THEME HOOK: 'upgrade_status_ascii_export' -->
<!-- BEGIN OUTPUT from 'modules/contrib/upgrade_status/templates/upgrade-status-ascii-export.html.twig' -->
CUSTOM PROJECTS
--------------------------------------------------------------------------------
Brightcove
Scanned on Thu, 10/22/2020 - 16:41.

1 error found. 5 warnings found.

web/modules/contrib/brightcove/brightcove.drush.inc:
┌──────────┬──────┬────────────────────────────────────────────┐
│  STATUS  │ LINE │                  MESSAGE                   │
├──────────┼──────┼────────────────────────────────────────────┤
│ Check    │ 33   │ Call to deprecated function drush_print(). │
│ manually │      │                                            │
│ Check    │ 36   │ Call to deprecated function drush_print(). │
│ manually │      │                                            │
└──────────┴──────┴────────────────────────────────────────────┘

web/modules/contrib/brightcove/brightcove.install:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 227  │ Call to deprecated method applyUpdates() of class            │
│         │      │ Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface.   │
│         │      │ Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. │
│         │      │ Use                                                          │
│         │      │ \Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface:: │
│         │      │ getChangeList() and execute each entity type and field       │
│         │      │ storage update manually instead.                             │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/brightcove/modules/media_entity_brightcove/src/Plugin/MediaE
ntity/Type/BrightcoveVideo.php:
┌──────────┬──────┬────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                      MESSAGE                       │
├──────────┼──────┼────────────────────────────────────────────────────┤
│ Check    │      │ Class Drupal\media_entity\MediaTypeBase not found. │
│ manually │      │                                                    │
│ Check    │ 19   │ Class Drupal\media_entity\MediaTypeBase not found. │
│ manually │      │                                                    │
└──────────┴──────┴────────────────────────────────────────────────────┘

web/modules/contrib/brightcove/modules/media_brightcove/media_brightcove.info.ym
l:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

<!-- END OUTPUT from 'modules/contrib/upgrade_status/templates/upgrade-status-ascii-export.html.twig' -->

Removing the bot tag, since we're doing this manually. Feel free to add it back if needed.

Only Open issue after the Merge Request

 ------ ---------------------------------------------------------------------------------
  Line   modules/media_entity_brightcove/src/Plugin/MediaEntity/Type/BrightcoveVideo.php
 ------ ---------------------------------------------------------------------------------
         Class Drupal\media_entity\MediaTypeBase not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
  19     Class Drupal\media_entity\MediaTypeBase not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ ---------------------------------------------------------------------------------

 [ERROR] Found 2 errors

Hi there!

I've performed a 8.9 to 9.1 upgrade using the branch from the PR, and the functionality seems to work. Note, my primary use case is syndicating Brightcove Videos within the Drupal site, nothing too fancy.

The Composer management didn't work 100% as expected, as I had to explicitly require drupal/time_formatter. I expect I'd need to require drupal/inline_entity_form as well, but I already had it. These two dependencies should be declared in the main composer.json for this project. I didn't notice any other non-core dependencies.

Speaking of the Time Formatter, it'd be grand to roll a 2.x.x release (alpha?) so there's something specific to pull in, as opposed to a potentially-constantly changing dev.

As for the remaining issues in the upgrade status report, those pertain to the contrib media_entity which has been deprecated for quite some time. We should either (1) leave this as-is, or (2) remove this submodule and roll a new 3.x.x branch where D9 compatibility is introduced.

Let me know if there's anything further I can do to push this ahead. Thanks!

Hi there, just checking back in to see if anyone had any thoughts/feedback/etc on pushing this forward. This is the last of the dependencies holding up one of my projects from upgrading to D9. This is a doozey of a module, I get it, but let me know if there's anything I can do to assist.

Thanks!

Same problem here with drupal/time_formatter, @kerasai, too, when i require it from my main composer.json (in my project), no is working with brightcove library :(

For anyone who are trying to install brightcove on D9 here is the guide :
1. First install the latest dev version of time_formatter module using composer require 'drupal/time_formatter:2.0.x-dev@dev'
2. Follow this guide to install latest dev version of Brighcove module on Drupal 9 site https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-8-to-...
3.Apply the attached patch.
4.Execute composer update drupal/brightcove

Updated patch #11 with removing Core:8.x from info.yml files

Patch #12 applied successfully, but was completely broken as far as API Client config load, save, and delete were concerned. These issues were not new to #12. I've fixed the issues I found in the existing patch code and added the config_export declaration in Entity/BrightcoveApiClient. This resolved the issues for me.

Patch #13 applied successfully.

Hi all,
I have applied the #13 patch and getting the error:
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "entity.manager". in Drupal\Component\DependencyInjection\Container->get() (line 151 of core/lib/Drupal/Component/DependencyInjection/Container.php).
when try to add Brightcove video.
I see in the BrightcoveVideoPlaylistForm.php file is still used the service "entity.manager" although it was removed in 9 version.

Updated patch #13 to fix the https://www.drupal.org/project/brightcove/issues/3146320#comment-14077776 issue

This PR now covers all the fixes from Previous PR + Patch files shared in this thread

https://git.drupalcode.org/project/brightcove/-/merge_requests/2#note_23213

Anyone interested in using this latest PR Code, then you can download the patch & lever it via your composer.

Hi gobinathm,

I've found an issue with the D9 patch:

TypeError: Argument 1 passed to Drupal\brightcove\Form\BrightcoveVideoPlaylistForm::__construct() must be an instance of Drupal\Core\Entity\EntityTypeBundleInfo,
instance of Drupal\Core\Entity\EntityManager given, called in /var/www/adg/docroot/modules/contrib/brightcove/src/Form/BrightcoveVideoPlaylistForm.php on line 45 in Drupal\brightcove\Form\BrightcoveVideoPlaylistForm->__construct() (line 34 of modules/contrib/brightcove/src/Form/BrightcoveVideoPlaylistForm.php).

This occurred while I was testing the patch locally, and edited a video.

I'm looking into an update to the patch now.

I have applied the patch, but i still getting the error like in #18

Updated patch #14 to fix the error below using an use statement.

Error: Class 'Drupal\brightcove\Entity\NodeInterface' not found in Drupal\brightcove\Entity\BrightcoveVideoPlaylistCmsEntity->setPublished()

I'm encountering the same problem, I think, that @hidabe mentioned in #10. The brightcove composer.json requires drupal/time_formatter ^1.0, even though we need to be using 2.0.x-dev@dev. Specifying the latter in the root composer.json causes composer to throw an error on update, of course:

Root composer.json requires drupal/time_formatter 2.0.x-dev@dev, ^1.0, found drupal/time_formatter[dev-1.x, dev-2.0.x, 1.0.0, 1.x-dev (alias of dev-1.x), 2.0.x-dev (alias of dev-2.0.x)] but it does not match the constraint.

So it seems to me that it needs to be changed in the brightcove composer.json. Does this need to be patched, or am I the only one still experiencing this?

*Editing to correct myself: This isn't something that can be patched; since this is a change to a composer-moderated dependency in a composer.json file, any attempt to fix this in a patch will be ignored by composer; the fix needs to be made directly to the project code.

Closing ticket as it is already solved by https://git.drupalcode.org/project/brightcove/-/merge_requests/11 (and 12, 13)