Similar to #1635446: problem when path alias contains utf8 characters for the 7.x version, the following valid URLs all responded with 404 when the fast_404 module was enabled:

‘outstanding-efforts’
‘class-act’
social-media-news-–-did-you-know

Steps to replicate

- Create a new content page with the urls alias "outstanding-efforts"
- Visited the page - and verify if it can be accessed
- Enable the module
- Visited the newly created page again should results in 404
- Apply the patch
- Clear cache
- Verify if the page can be accessed now

Comments

malcomio created an issue. See original summary.

malcomio’s picture

Status: Active » Needs review
Related issues: +#1635446: problem when path alias contains utf8 characters
StatusFileSize
new651 bytes
malcomio’s picture

StatusFileSize
new6.33 KB

The previous patch included some unnecessary changes, taken from the patch on #1635446: problem when path alias contains utf8 characters

malcomio’s picture

StatusFileSize
new571 bytes

Sorry - the previous patch had the wrong git root.

joseph.olstad’s picture

we are using this patch, thanks it seems to work properly..

here is our working configuration details:

see our configuration details here:
https://www.drupal.org/project/fast_404/issues/2961512#comment-14040732

kristen pol’s picture

@joseph.olstad Do you feel comfortable RTBCing this since you've tested it?

joseph.olstad’s picture

@Kristen Pol

The patch appeared to work for us but I didn't spent enough time with the client and reviewing this to be 100% confident. I am no longer doing work for the client that asked me to implement this so I am not sure how well this worked out in the long term.

kristen pol’s picture

Issue tags: +Needs manual testing

Thanks for the feedback. Marking for manual testing.

joshua1234511’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Tested the patch from #4

Steps followed
- Created a new content page with the urls alias "outstanding-efforts"
- Visited the page - can be accessed
- Enabled the module
- Visited the url results in 404
- Applied the patch
- Cleared cache
- The page can be accessed now

Based on the test results marking the issue as RTBC

kristen pol’s picture

Thanks @joshua1234511! This is ready to be merged by a maintainer :)

joseph.olstad’s picture

Version: 8.x-2.x-dev » 8.x-3.x-dev
joseph.olstad’s picture

triggered tests for 8.x-3.x branch

kristen pol’s picture

Assigned: Unassigned » kristen pol
Priority: Normal » Major

Moving this to major as it is a big deal and pretty much equivalent to a "fatal error" without the WSOD. Assigning to me to see if I can get this in.

  • Kristen Pol committed 7c8d9d5a on 8.x-2.x authored by malcomio
    Issue #3144403 by malcomio, joseph.olstad, Kristen Pol, joshua1234511:...

  • Kristen Pol committed cc2ade02 on 8.x-3.x authored by malcomio
    Issue #3144403 by malcomio, joseph.olstad, Kristen Pol, joshua1234511:...
kristen pol’s picture

Assigned: kristen pol » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks, everyone! This has been merged for both 2.x and 3.x and will be in the next 3.x release though I don't think there will be any more 2.x releases.

joseph.olstad’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.