When serving page with URIs containing utf8 chars with fast_404_path_check(), depending on server configuration, queries might return false even if given path does exist in backend, but was rewriten to utf-8 enabled string.

To prevent this we should explicitly set database connection charset.

Comments

GrzegorzNowak’s picture

StatusFileSize
new1013 bytes

attaching sample patch agains 6.x-1.x branch

soyarma’s picture

What possible reprecussions could this have if the data is not UTF-8

madhavvyas’s picture

Issue summary: View changes
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: utf8-db-connection-1635446-1.patch, failed testing.

madhavvyas’s picture

Issue tags: +Needs reroll
madhavvyas’s picture

Status: Needs work » Needs review
StatusFileSize
new597 bytes

Patch re rolled #1

madhavvyas’s picture

Issue tags: -Needs reroll

Status: Needs review » Needs work

The last submitted patch, 6: utf8-db-connection-1635446-5.patch, failed testing.

ragnarkurm’s picture

StatusFileSize
new699 bytes

Upgraded the patch.
It is for 7x.1.x branch.
Dev branch seems to be abandoned.

ragnarkurm’s picture

StatusFileSize
new690 bytes

Here is updated version.
We need UTF also for redirect checking.

ragnarkurm’s picture

Version: 6.x-1.x-dev » 7.x-1.5

Changing the version to 7.x-1.5,
since working patches are for that version.
They can be back-ported if needed.

ragnarkurm’s picture

Status: Needs work » Needs review