Font-your-face view display

Hi, created a patch 3143782-3.patch for Claro 8.x-1.0-beta1. Please check screenshot

Moving to the Drupal core queue because Claro has been moved to Drupal core.

#5 Committed patch failed for D8.9 hence moving it to needs work to re-roll the patch.

Here I have added a re-roll of patch #5 for Drupal 9.1.x.

Hi @ravi.shankar The patch needs to be recreated as pcss.css files are missing and must be verified with Font-your-face module but when i verified the Font-your-face module seems not compatible with D9 hence this issue is blocked till then.

The font your face module is not compatible with Drupal 9, so setting this to postponed. This is probably more appropriate as an issue in font-your-face, but I'm not certain of that. I am

+++ b/core/themes/claro/css/layout/layout.css
@@ -28,3 +28,18 @@
+}

I do know that the current approach in the patches will definitely not work as it changes the styles for item-list ul, h4 and h5 elements everywhere in Claro. This will break styling in a number of places. The selectors will need to be more targeted. If that targeting is a selector added by font-your-face, then the change should be in that module. I recommend moving it there but won't do the moving in case there was a specific reason for adding it as a Claro issue that I'm unaware of.

If I am reading this correctly, this was postponed because @font-your-face is not compatible with Drupal 9. That was fixed in #3042792: Drupal 9 Deprecated Code Report, so setting to active.

I have themed the @font-your-face view. I have attached patch for same. please review

+++ b/core/themes/claro/css/components/views-ui.pcss.css
@@ -574,3 +574,121 @@ details.fieldset-no-legend {
+.view-fontyourface-font-manager {

There is no core fontyourface view, and this entire patch is based on styling a fontyourface view. This would absolutely not be commite to core as it's styling something that isn't in core - it's something you get from a specific contrib module.

If this is the desired approach , then it should be added to https://www.drupal.org/project/fontyourface, not core.

If you opt for a more generic solution (one that doesn't have CSS full of 'fontyourface'), it could go in core.

I agree with @bnjmnm that the patch should be applied to the "fontyourface" module, not Claro, because view display appears to be an issue when this module is installed, and the issue is now tagged to version 11.x-dev, where the fontyourface module is not available; it is only available till Drupal 10. I think tagging should be corrected.

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

Claro has moved to contrib

But this needs an IS update before it can be worked on