The Metatag Google Scholar module provides number of meta tags to help with
indexing of scholarly content/articles in Google Scholar.

Currently the module adds the following Highwire Press tags:

  • citation_title
  • citation_author
  • citation_publication_date
  • citation_journal_title
  • citation_issn
  • citation_isbn
  • citation_volume
  • citation_issue
  • citation_firstpage
  • citation_lastpage
  • citation_dissertation_institution
  • citation_technical_report_institution
  • citation_technical_report_number
  • citation_pdf_url

Project link

https://www.drupal.org/project/metatag_google_scholar

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/metatag_google_scholar.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-metatag_google...

Comments

antongp created an issue. See original summary.

manish34jain’s picture

manish34jain commented
Issue summary: View changes
manish34jain’s picture

manish34jain commented

Hello antongp,

Checked and fixed issues using pareview.sh

Review of the 8.x-1.x branch (commit ff982f5):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
  5 | WARNING | Line exceeds 80 characters; contains 86 characters
 63 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/metatag_google_scholar.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 9 | WARNING | Line exceeds 80 characters; contains 87 characters
--------------------------------------------------------------------------

Time: 676ms; Memory: 4Mb
  • DrupalPractice has found some issues with your code, but could be false positives.
    
FILE: .../pareview_temp/tests/src/Functional/MetatagGoogleScholarTagsTest.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 38 | WARNING | Unused variable $modules.
--------------------------------------------------------------------------

Time: 328ms; Memory: 4Mb

This automated report was generated with PAReview.sh, your friendly project application review script.

antongp’s picture

antongp commented

Thank you for your review.

The issues are fixed in latest 8.x-1.x, though they are warnings.

README.md is fixed by adding extra line breaks.

metatag_google_scholar.install is fixed by shortening the description without affecting its sense much. Adding line break would cause an error because short description must be one line. Function doesn't do much to provide short and long descriptions, and also drush updatedb command has some issues with showing long descriptions.

MetatagGoogleScholarTagsTest.php also fixed.

I also repeated PAReview review - it shows empty report now.

Thanks again.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Fixed

Looks good to me after a manual code review.

Thanks for your contribution, Anton!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

antongp’s picture

antongp commented

Many thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.