Replace usages of AssertLegacyTrait::assertText, that is deprecated

Thanks for working on this

This is a very big elephant, that will be probably have to be sliced for eating. IMHO we should wait for most of the #3027952: [Plan] Remove the usage of deprecated methods in tests sub-issues to be done before, maybe also for #2549805: [Meta] Remove all usage of FormattableMarkup in tests apart from explicit tests of that API. Then find ways to break this down into smaller patches (e.g. separate assertText from assertNoText, split base classes+traits from concrete test, etc).

Similarly to #3139409: Replace usages of AssertLegacyTrait::assertRaw, that is deprecated, I would suggest splitting this issue in 3:

1) a first issue to remove the $message parameter from calls to assertText and assertNoText. This is already redundant as in the legacy trait these methods are defined as protected function assertText($text). Suggest following #3131946: [policy] Remove PHPUnit assertion messages when possible, and standardize remaining messages for guidelines when a $message should be converted to an inline comment.
2) a second issue to remove the calls to t() from calls to assertText, unless we are testing the translation layer.
3) finally this one that at that point will be simply a find and replace exercise.

Filed #3159788: AssertLegacyTrait::assert(No)Text() in functional tests still have a message passed in

I am splitting this in two, one for assertText and one for assertNoText, since the conversions are not as straightforward as it may seem.

Green! Ready for review.

@daffie re. #24 obviously, this is a big patch. I'd leave that decision to committers. Personally, I respect the need to minimise the impact of large changes. OTOH, I see that having only a 10 days window every 6 months to get those done, the risk is that it will take a long time to do them especially if you need to start doing a big one only after another big one is committed. For example, these remaining Simpletest deprecations

      // Simpletest's legacy assertion methods.
      'UiHelperTrait::drupalPostForm() is deprecated in drupal:9.1.0 and is removed from drupal:10.0.0. Use $this->submitForm() instead. See https://www.drupal.org/node/3168858',
      'AssertLegacyTrait::assertEqual() is deprecated in drupal:8.0.0 and is removed from drupal:10.0.0. Use $this->assertEquals() instead. See https://www.drupal.org/node/3129738',
      'AssertLegacyTrait::assertNotEqual() is deprecated in drupal:8.0.0 and is removed from drupal:10.0.0. Use $this->assertNotEquals() instead. See https://www.drupal.org/node/3129738',
      'AssertLegacyTrait::assertIdentical() is deprecated in drupal:8.0.0 and is removed from drupal:10.0.0. Use $this->assertSame() instead. See https://www.drupal.org/node/3129738',
      'AssertLegacyTrait::assertText() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseContains() or $this->assertSession()->pageTextContains() instead. See https://www.drupal.org/node/3129738',
      'AssertLegacyTrait::assertNoText() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseNotContains() or $this->assertSession()->pageTextNotContains() instead. See https://www.drupal.org/node/3129738',
      'AssertLegacyTrait::assertRaw() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseContains() instead. See https://www.drupal.org/node/3129738',
      'AssertLegacyTrait::assertNoRaw() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->responseNotContains() instead. See https://www.drupal.org/node/3129738',

are all pretty large, interdependent one to the other, and non-trivial (it's not just renaming the method, we need to check order of arguments, select the appropriate method in some cases, etc...).

Same here, @daffie :)

Rerolled

Rerolled to solve conflicts introduced by commit of #3131281: Replace assertEqual() with assertEquals().

Confirmed, +1 for RTBC

https://drupal.slack.com/archives/C1BMUQ9U6/p1621515755041300

RTBC; as far as I can see, this is only removing lines with assertText(...) and adding lines with pageTextContains(...) or responseContains(...).

Working on #3191935: Replace usages of AssertLegacyTrait::assertNoText, which is deprecated I now realize that this conversion may be impacted by #3175718: Random fails due to drupal-settings-json being counted as page text in the sense that if an expected text is found in the drupal-settings-json but not in the user visible page, still the assertion would pass.