Problem/Motivation

This issue is a child issue from #3145418: [November 9, 2020] Remove uses of t() in assertText() calls because if fix uses of t() in assertNoText() the patch would be to big and difficult to review.

Proposed resolution

Fix uses of t() in assertNoText(). Tests should not have t() calls inside assertNoText(). Only if it is testing translation.

CommentFileSizeAuthor
#12 interdiff_9-12.txt2.43 KBsnehalgaikwad
#12 3166349-12.patch76.02 KBsnehalgaikwad
#9 3166349-3.patch76.17 KBnaresh_bavaskar
#5 interdiff.txt2.03 KBpaulocs
#5 3166349-3.patch76.17 KBpaulocs
#3 3166349-2.patch76.95 KBpaulocs

Comments

paulocs created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

I will work on it.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: paulocs » Unassigned
Status: Active » Needs review
StatusFileSize
new 3166349-2.patch76.95 KB

Patch to remove all t() calls inside assertNoText().
Please review it.

Cheers, Paulo

Status: Needs review » Needs work

The last submitted patch, 3: 3166349-2.patch, failed testing. View results

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
StatusFileSize
new 3166349-3.patch76.17 KB
new interdiff.txt2.03 KB

Fixing errors.

Status: Needs review » Needs work

The last submitted patch, 5: 3166349-3.patch, failed testing. View results

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs work » Needs review

#5 patch looks good to me..might random test cases were failed. trying to re-upload it.

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
StatusFileSize
new 3166349-3.patch76.17 KB

Status: Needs review » Needs work

The last submitted patch, 9: 3166349-3.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented 
  1. +++ b/core/modules/contact/tests/src/Functional/ContactSitewideTest.php
@@ -226,7 +226,7 @@ public function testSiteWideContact() {
     $this->addContactForm($name, $label, '', '', FALSE);
-    $this->assertNoText(t('Contact form @label has been added.', ['@label' => $label]));
+    $this->assertNoText('Contact form $label has been added.');
...

    The string should be enclosed in double quotes (") in order for $label to be replaced with the variable's value. 

  2. +++ b/core/modules/forum/tests/src/Functional/ForumTest.php
@@ -581,7 +581,7 @@ public function createForumTopic($forum, $container = FALSE) {
+      $this->assertNoText('$type $title has been created.', 'Forum topic was not created');

    same 

  3. +++ b/core/modules/user/tests/src/Functional/UserPasswordResetTest.php
@@ -375,7 +375,7 @@ public function testUserResetPasswordUserFloodControlIsCleared() {
-    $this->assertNoText(t('Sorry, @name is not recognized as a username or an e-mail address.', ['@name' => $name]), 'Validation error message shown when trying to request password for invalid account.');
+    $this->assertNoText('Sorry, $name is not recognized as a username or an e-mail address.', 'Validation error message shown when trying to request password for invalid account.');

    same

snehalgaikwad’s picture

snehalgaikwad commented
Status: Needs work » Needs review
StatusFileSize
new 3166349-12.patch76.02 KB
new interdiff_9-12.txt2.43 KB

Changed string quotes to double as per #11.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Thank you.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +Deprecated assertions

  • catch committed f4fd2d7 on 9.1.x 
    Issue #3166349 by paulocs, snehalgaikwad, naresh_bavaskar, mondrake:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed f4fd2d7 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.