Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In #3145418-47: [November 9, 2020] Remove uses of t() in assertText() calls we found more cases of assertNoText called with an object argument.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#32 | 3176200-32.patch | 1.66 KB | adityasingh |
Comments
Comment #2
mondrakeDiscovery patch.
Comment #3
mondrakeComment #5
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedComment #6
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedGiven a start to this issue.
Comment #7
msutharsComment #8
msutharsFix the test case issue. Updated the patch.
Comment #9
mondrakeThank you - to clarify: the intent here is not to convert all the instances, just those that are reasonable. With this perspective:
This can be reverted.
I think this can be just
$this->assertNoText('Configuration deletions');
since it does not look like in this test the translation layer is involved at all.This can be reverted, see #3145418-61: [November 9, 2020] Remove uses of t() in assertText() calls and later comments
this can be removed now as it has served its purpose
Comment #10
msutharsComment #11
msutharsUpdated the patch as suggested in #9. Please review.
Comment #12
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
As #9 comment in point 2 mentioned as to be $this->assertNoText('Configuration deletions'); statement.
I am creating updated patch as cover all points and removed what it points.
Please review the patch.
Thanks.
Comment #13
msuthars@Pooja Ganjage The patch in #12 is not applying so I'm adding the updated patch.
Comment #14
msutharsComment #15
msutharsComment #16
mondrakeThank you.
Comment #18
mondrakeComment #19
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
Creating a reroll patch for latest version of drupal 9.2.x-dev.
Please review the patch.
Thanks.
Comment #20
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #21
longwaveNeeds another reroll :(
Comment #22
adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedReroll for 9.2.x
Comment #23
mondrakeThese should be reverted as they are out of scope here at this point.
Comment #24
adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedUpdated patch as suggested in #23.
Comment #25
longwaveWhile we're here let's fix this easy one:
Comment #26
adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedUpdated patch as suggested in #25.
Comment #27
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #28
mondrakeComment #29
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #30
mondrakeHi, we are missing the changes from #24 in the last patches - we need them as well :)
Comment #31
longwaveSorry, I think I should spin off #25 to another issue as there are other similar cases, and we should go back to #24.
Comment #32
adityasingh CreditAttribution: adityasingh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedReuploading the patch #24. As discussed in #31. Please review.
Thanks...
Comment #33
mondrakeThanks
Comment #36
catchCommitted/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!
Comment #37
longwaveOpened #3184493: Remove use of concatenated t() in assertions to follow up on #25