AssertLegacyTrait::assert(No)Text() in functional tests still have a message passed in

Initial, discovery, patch.

@ravi.shankar be careful not to lose important context information when removing the message. In that case, a comment should be provided.

Looking at your interdiff,

1. +++ b/core/modules/user/tests/src/Functional/UserCancelTest.php
   @@ -325,13 +325,13 @@ public function testUserAnonymize() {
   -    $this->assertText(t('Are you sure you want to cancel your account?'), 'Confirmation form to cancel account displayed.');
   +    $this->assertText(t('Are you sure you want to cancel your account?'));
   

   is ok because the message is just redundant, but

2. +++ b/core/modules/user/tests/src/Functional/UserCreateTest.php
   @@ -108,16 +108,16 @@ public function testUserAdd() {
          $this->drupalGet('admin/people');
   -      $this->assertText($edit['name'], 'User found in list of users');
   +      $this->assertText($edit['name']);
          $user = user_load_by_name($name);
   
   +++ b/core/modules/user/tests/src/Functional/UserTimeZoneTest.php
   @@ -61,40 +61,40 @@ public function testUserTimeZone() {
        // Confirm date format and time zone.
        $this->drupalGet('node/' . $node1->id());
   -    $this->assertText('2007-03-09 21:00 0', 'Date should be PST.');
   +    $this->assertText('2007-03-09 21:00 0');
        $this->drupalGet('node/' . $node2->id());
   -    $this->assertText('2007-03-11 01:00 0', 'Date should be PST.');
   +    $this->assertText('2007-03-11 01:00 0');
        $this->drupalGet('node/' . $node3->id());
   -    $this->assertText('2007-03-20 21:00 1', 'Date should be PDT.');
   +    $this->assertText('2007-03-20 21:00 1');
   ...
        // Confirm date format and time zone.
        $this->drupalGet('node/' . $node1->id());
   -    $this->assertText('2007-03-10 02:00 1', 'Date should be Chile summer time; five hours ahead of PST.');
   +    $this->assertText('2007-03-10 02:00 1');
        $this->drupalGet('node/' . $node2->id());
   -    $this->assertText('2007-03-11 05:00 0', 'Date should be Chile time; four hours ahead of PST');
   +    $this->assertText('2007-03-11 05:00 0');
        $this->drupalGet('node/' . $node3->id());
   -    $this->assertText('2007-03-21 00:00 0', 'Date should be Chile time; three hours ahead of PDT.');
   +    $this->assertText('2007-03-21 00:00 0');
   

   are NOT OK because you are losing information (in the first case, that you are checking in a list, in the others 'why' a specific datetime is checked for). See the previous patches to see how to add an inline comment in that case. In case of doubt in a specific case, it's better add the comment anyway.

@ravi.shankar please unassign yourself from issues when you are not working on them. You currently are assigned on 7 active issues, which is unlikely you are concurrently working on.

With proper deprecation message and deprecation tests.

Dammit, I just spent two hours reviewing with dreditor in light of #10, there are still so many cases where we lose important context information when removing the message. Then clicked on 'save' and 'paste' and puff - all lost.

I wonder if we can move this issue to merge request, and comment a bit more solidly in gitlab?

Requested in #3167029-31: Opt-in core issues into the Drupal.org Issue Forks and Merge Requests Beta

Let's wait for #3145418: [November 9, 2020] Remove uses of t() in assertText() calls, and note that in this issue we no longer use patches, but rather we should git the issue fork and push changes to it.

Please do not post patches, use the new merge request workflow instead.

Reviewing to check losses of context by removing the message.

I finished my review.

Thanks for review @longwave! I have made some changes and commented over some of your comments, where I thinkwe should defer your suggestion to other issues to avoid scope creep. And yes, for large patches like this one the gitlab review workflow is certainly a big step forward.

Rerolled

Done! Thanks

@catch do we need a 9.1.x patch here, or we leave this with 9.2.x?

Here's a 9.1 patch.

Tentatively RTBC, this is just the 9.2.x commit + fix of #77.