Ran drupal-check and found 21 errors:

16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------- 
  Line   date_time_day.module                                                  
 ------ ---------------------------------------------------------------------- 
  16     Call to deprecated method url() of class Drupal:                      
         in drupal:8.0.0 and is removed from drupal:9.0.0.                     
         Instead create a \Drupal\Core\Url object directly, for example using  
         Url::fromRoute().                                                     
  20     Call to deprecated method url() of class Drupal:                      
         in drupal:8.0.0 and is removed from drupal:9.0.0.                     
         Instead create a \Drupal\Core\Url object directly, for example using  
         Url::fromRoute().                                                     
 ------ ---------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   src/DateDayComputed.php                                                                                                     
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  47     Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use  
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.                                 
  49     Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use     
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.                                    
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldFormatter/DateTimeDayDefaultFormatter.php      
 ------ --------------------------------------------------------------------- 
  151    Call to deprecated function datetime_date_default_time():            
         in drupal:8.5.0 and is removed from drupal:9.0.0. Use                
         \Drupal\Component\Datetime\DateTimePlus::setDefaultDateTime() or     
         \Drupal\Core\Datetime\DrupalDateTime::setDefaultDateTime() instead.  
 ------ --------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldType/DateTimeDayFieldItemList.php                                                                     
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  139    Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use     
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.                                    
  140    Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use  
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.                                 
  146    Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use     
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.                                    
  153    Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use     
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.                                    
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldType/DateTimeDayItem.php                                                                              
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  121    Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use  
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.                                 
  126    Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use  
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.                                 
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/DateTimeDaySecondsWidget.php                                                                   
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  32     Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use  
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.                                 
  45     Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use  
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.                                 
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/DateTimeDayWidgetBase.php                                                                      
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  66     Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use  
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.                                 
  68     Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use     
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.                                    
  89     Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use     
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.                                    
  111    Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use     
         \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.                                    
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/src/Functional/DateTimeDayFieldTest.php                                      
 ------ ----------------------------------------------------------------------------------- 
  197    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:  
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                              
         mb_strtolower() instead.                                                           
  214    Call to deprecated function entity_get_form_display():                             
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use                              
         EntityDisplayRepositoryInterface::getFormDisplay() instead.                        
 ------ ----------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/DateTimeDayItemTest.php                                           
 ------ ----------------------------------------------------------------------------------- 
  50     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:  
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                              
         mb_strtolower() instead.                                                           
 ------ ----------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/SeparatorsTranslationTest.php                                     
 ------ ----------------------------------------------------------------------------------- 
  62     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:  
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                              
         mb_strtolower() instead.                                                           
 ------ ----------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 21 errors
CommentFileSizeAuthor
#4 before_patch.png390.67 KBankitsingh0188
#3 after_patch.png16.19 KBankitsingh0188
#3 before_patch_2.png118.18 KBankitsingh0188
#3 before_patch_1.png398.39 KBankitsingh0188
#3 before_patch.png390.67 KBankitsingh0188
#2 D9-3138880-2.patch15.15 KBdishabhadra

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: dishabhadra » Unassigned
Status: Active » Needs review
StatusFileSize
new D9-3138880-2.patch15.15 KB

Created the patch.

Checked using Upgrade status and drupal-check no errors found.

 16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors
ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png390.67 KB
new before_patch_1.png398.39 KB
new before_patch_2.png118.18 KB
new after_patch.png16.19 KB

Before Patch:
before_patch
before_patch
before_patch

After Patch:
Patch applied successfully and no errors were found after running the drupal-check utility.

Looks good to me. Good to move it to RTBC.
after applying patch

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
Location Pune
commented
StatusFileSize
new before_patch.png390.67 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -Drupal 9 compatibility Drupal 9 porting weekend DIACWMay2020 +Drupal 9 compatibility, +Drupal 9 porting weekend, +DIACWMay2020

Fixing tags.

andriy khomych’s picture

andriy khomych commented

Hello all!
Thank you for participating, I'll review it as soon as possible.

andriy khomych’s picture

andriy khomych commented
Related issues: +#3140180: Automated Drupal 9 compatibility fixes, +#3138885: Drupal 9 readiness, +#3065325: Remove all deprecated code (DATETIME_DATE_STORAGE_FORMAT and datetime_date_default_time())
andriy khomych’s picture

andriy khomych commented
Version: 8.x-1.4 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Thank you all for participating. I don't know why the commit didn't appear here, but I've used the commit message.
Meanwhile, I've updated some module code so I've partially copied code from patch to apply it properly.

If you wanna support this module more, please, ping me via the contact form. I'll add you to maintainers.

Thanks a lot!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.