Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Ran drupal-check
and found 21 errors:
16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ----------------------------------------------------------------------
Line date_time_day.module
------ ----------------------------------------------------------------------
16 Call to deprecated method url() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Instead create a \Drupal\Core\Url object directly, for example using
Url::fromRoute().
20 Call to deprecated method url() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Instead create a \Drupal\Core\Url object directly, for example using
Url::fromRoute().
------ ----------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------------
Line src/DateDayComputed.php
------ ----------------------------------------------------------------------------------------------------------------------------
47 Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.
49 Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.
------ ----------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------
Line src/Plugin/Field/FieldFormatter/DateTimeDayDefaultFormatter.php
------ ---------------------------------------------------------------------
151 Call to deprecated function datetime_date_default_time():
in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\Component\Datetime\DateTimePlus::setDefaultDateTime() or
\Drupal\Core\Datetime\DrupalDateTime::setDefaultDateTime() instead.
------ ---------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/Field/FieldType/DateTimeDayFieldItemList.php
------ ----------------------------------------------------------------------------------------------------------------------------
139 Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.
140 Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.
146 Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.
153 Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.
------ ----------------------------------------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/Field/FieldType/DateTimeDayItem.php
------ ----------------------------------------------------------------------------------------------------------------------------
121 Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.
126 Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.
------ ----------------------------------------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/Field/FieldWidget/DateTimeDaySecondsWidget.php
------ ----------------------------------------------------------------------------------------------------------------------------
32 Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.
45 Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.
------ ----------------------------------------------------------------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/Field/FieldWidget/DateTimeDayWidgetBase.php
------ ----------------------------------------------------------------------------------------------------------------------------
66 Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.
68 Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.
89 Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.
111 Call to deprecated constant DATETIME_STORAGE_TIMEZONE: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE instead.
------ ----------------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------
Line tests/src/Functional/DateTimeDayFieldTest.php
------ -----------------------------------------------------------------------------------
197 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strtolower() instead.
214 Call to deprecated function entity_get_form_display():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
EntityDisplayRepositoryInterface::getFormDisplay() instead.
------ -----------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------
Line tests/src/Kernel/DateTimeDayItemTest.php
------ -----------------------------------------------------------------------------------
50 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strtolower() instead.
------ -----------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------
Line tests/src/Kernel/SeparatorsTranslationTest.php
------ -----------------------------------------------------------------------------------
62 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strtolower() instead.
------ -----------------------------------------------------------------------------------
[ERROR] Found 21 errors
Comment | File | Size | Author |
---|---|---|---|
#4 | before_patch.png | 390.67 KB | ankitsingh0188 |
#3 | after_patch.png | 16.19 KB | ankitsingh0188 |
#3 | before_patch_2.png | 118.18 KB | ankitsingh0188 |
#3 | before_patch_1.png | 398.39 KB | ankitsingh0188 |
#2 | D9-3138880-2.patch | 15.15 KB | dishabhadra |
|
Comments
Comment #2
dishabhadra CreditAttribution: dishabhadra at Axelerant commentedCreated the patch.
Checked using
Upgrade status
anddrupal-check
no errors found.Comment #3
ankitsingh0188Before Patch:
After Patch:
Patch applied successfully and no errors were found after running the drupal-check utility.
Looks good to me. Good to move it to RTBC.
Comment #4
ankitsingh0188Comment #5
Gábor HojtsyFixing tags.
Comment #6
Andriy Khomych CreditAttribution: Andriy Khomych as a volunteer commentedHello all!
Thank you for participating, I'll review it as soon as possible.
Comment #7
Andriy Khomych CreditAttribution: Andriy Khomych as a volunteer commentedComment #8
Andriy Khomych CreditAttribution: Andriy Khomych as a volunteer commentedThank you all for participating. I don't know why the commit didn't appear here, but I've used the commit message.
Meanwhile, I've updated some module code so I've partially copied code from patch to apply it properly.
If you wanna support this module more, please, ping me via the contact form. I'll add you to maintainers.
Thanks a lot!