Problem/Motivation

Pointed out by @xjm in Slack:

"We need to update the styling/logo here for D9"

D9 status report with D8 branding

Proposed resolution

Fix the branding for this.
We can use the new "evergreen" Drupal logo - see #3134326: Adopt the 2020 (evergreen) Drupal logo in Drupal core

Remaining tasks

  1. Decide what we should do.
  2. Do it.
  3. Reviews/improvements.
  4. RTBC.
  5. Commit.

User interface changes

Change the branding on the status report:

Screenshot of the status report on 9.0.0-dev with the new version-agnostic Drupal logo

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Comments

dww created an issue. See original summary.

dww credited xjm.

dww’s picture

shaal’s picture

I removed the old logod8-logo.svg and added the new one drupal-evergreen-logo.svg.
I replaced all instances that the old logo appeared with the new one.

Discussion about Drupal evergreen logo's license can be found here: #3134326: Adopt the 2020 (evergreen) Drupal logo in Drupal core

Screenshot after this patch applied:
Screenshot with the evergreen logo patch

xjm’s picture

Status: Active » Needs review
gábor hojtsy’s picture

My understanding is this would need a switch resolution of #3134326: Adopt the 2020 (evergreen) Drupal logo in Drupal core (the legal parts) first?

hestenet’s picture

Working on a usage policy for brand elements that can be included in core, so that we can make this change and update the new brand elements. Hope to have that policy ready tomorrow.

See #3134326: Adopt the 2020 (evergreen) Drupal logo in Drupal core

dww’s picture

Screenshot from #4 looks great, thanks!

It appears that the legal policy stuff is moving forward nicely, such that this is a legit use of the evergreen logo. Draft policy: https://www.drupal.org/about/media-kit/copyright-and-trademark

We encourage service providers in the Drupal business ecosystem to refer to the Drupal project using the official Drupal brand materials. For example, a hosting company is encouraged to use the official Drupal logo in a listing of installable software on their hosting platform.

Seems like mentioning the Drupal version inside Drupal in the status report is somewhat similar to this quoted use case. IANAL, but it looks like we can proceed here.

One question on implementation details of #4: Do we really want duplicate copies of the evergreen svg in each core (admin) theme? Why not put it in core/misc or something and have all the admin themes re-use the same copy?

Thanks!
-Derek

shaal’s picture

@dww, re:

Do we really want duplicate copies of the evergreen svg in each core (admin) theme? Why not put it in core/misc or something and have all the admin themes re-use the same copy?

I think that would be a question for @lauriii, I just kept the file structure the way it is.

codersukanta’s picture

StatusFileSize
new44.75 KB
new43.75 KB

Tested the patch #4 on theme seven and claro. It looks great.

dww’s picture

Re: #9: When I asked in Slack, @xjm pasted these two links:

#3107186: Add a test to ensure that image assets are copied to Stable when a module or misc asset is updated
#3105209: [policy, no patch] as of Stable 9, do not copy image assets unless they have changed.

To which I replied:

Sure, but these are brand new (pardon the pun) assets. They're not diverging, or copied, or changing. They're the new, original canonical versions of the DA's branding assets. I don't see why they'd want to start life in a forked state. Plus, there's talk of including a separate license.txt file "in the subdirectory where they're distributed", which is going to be weird and clumsy if we have N copies floating around but no canonical copy.

gábor hojtsy’s picture

Status: Needs review » Needs work

@gisle in #3134326: Adopt the 2020 (evergreen) Drupal logo in Drupal core suggests to ship the logo in a distinct directory with a license.txt or license.md file that points to the https://www.drupal.org/about/media-kit/copyright-and-trademark URL (possibly not the final URL). I think that would only be practical if the file would indeed only appear once in core for this purpose at least and not in every single theme.

jungle’s picture

StatusFileSize
new6.94 KB

Should the 9.0 logo be used in the 9.0.x branch to celebrate the release of Drupal 9, especially?

gábor hojtsy’s picture

@jungle: I don' think that would make sense in the context of this issue, the version number is displayed right alongside it. If this image would be used, we would need to change it in each minor branch (there is already 9.1 and 9.0 open).

dww’s picture

@Gábor Hojtsy: Re: #12 👍

@jungle Re: #13: Agree with Gabor in #14 that we want the "evergreen" version of the logo for this, not a versioned version. ;)

Thanks,
-Derek

shaal’s picture

The following changes were made:

  • Latest changes from fixed evergreen logo (https://www.drupal.org/about/media-kit/logos)
  • Class name in template was changed to system-status-general-info__item-icon--drupal
  • Logo file was removed from theme directories and moved to 1 share file at core/misc/logo/drupal-evergreen-logo.svg
  • Added license.txt file, that should be updated with the right content.

@todo: finalize the content of license.txt

jungle’s picture

#14, #15, thanks for disagreement! :)

Logo file was removed from theme directories and moved to 1 share file at core/misc/logo/drupal-evergreen-logo.svg

Can we remove evergreen from the filename? Change it to core/misc/logo/drupal-logo.svg or core/misc/logo/drupal.svg?

As a non-native English speaker, It's my first time to know the word evergreen when the new logo released, never know it before. And before checking the dictionary and got the explanation from @Gábor Hojtsy on slack, at first glance, I thought it's the name of the new logo -- a name similar to Druplicon. 🤦

I do not think I am the only one got confused :p

shaal’s picture

In the official Drupal logos pack file it is called Evergreen Logo.
I'll be happy to change it if a different name would be better.

sja112’s picture

@jungle agreeing to your point,

As a non-native English speaker, It's my first time to know the word evergreen when the new logo released, never know it before.

It should be changed back to drupal-logo.svg, drupal.svg or to some other better name.

sja112’s picture

Can we change the file name to d9-evergreen-logo.svg or drupal9-logo.svg?

dww’s picture

@sja112: The point of "evergreen" is that it's not version-dependent. So "9" anywhere in the name is definitely not what we want.

sja112’s picture

@dww, Thanks for the quick response.

Can we remove evergreen from the name of the file? In my view, it should be changed to drupal-logo.svg.

jungle’s picture

Re #20, well, a good exmple of misunderstanding evergreen, no offense :)

evergreen === long live/forever, see similar replies in #14 and #15.

Both d9-evergreen-logo.svg or drupal9-logo.svg are inapplicable here, to me.

dww’s picture

@sja112 Re: #22:

Can we remove evergreen from the name of the file?

Perhaps. Not up to me. I'll defer to @hestenet, @xjm, @Gábor Hojtsy et al on that...

sja112’s picture

StatusFileSize
new7.7 KB
new2.22 KB

I am adding a patch here with the name drupal-logo.svg.

Keeping the issue status to needs work till the name is confirmed or new suggestion pops up.

Adding the patch for the testing.

Thanks!

gábor hojtsy’s picture

Status: Needs work » Reviewed & tested by the community

Drupal logo is fine. Drupal has the wordmark, the (software) logo and the mascot (Druplicon). So we can just call this the logo :) Looks like otherwise as well.

gábor hojtsy’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new907 bytes
new8.11 KB

Actually we can use sensible text that is not a problem if we don't come around to change it later. :) Also referencing it from COPYRIGHT.txt. Now I am not eligible to RTBC it though.

dww’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new27.98 KB

The updated LICENSE.txt text is great for now. We can always refine it later.

Very happy to see this in core/misc/logo now as its own thing. New filename is fine, happy to drop "evergreen" since it's obviously leading to confusion.

Tested manually. Looks great.

RTBC. Updating summary to cross off remaining tasks, clarify proposed resolution, and put the final screenshot in the UI changes section.

Thanks everyone!
-Derek

xjm’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs subsystem maintainer review

Nice, glad to see this sorted!

I find myself counting relative path segments in url() again... flashbacks to the theme decoupling work we did 4-5 months ago. I confirmed that only Seven and Claro have this branding with the D8 logo to begin with.

+++ b/core/COPYRIGHT.txt
@@ -57,3 +57,8 @@ PHP
+  Drupal brand materials under core/misc/logo have a dedicated license,
+  see core/misc/logo/LICENSE.txt

Comma splice, missing a period, and also wrapping too early ("see" can go on the previous line). So all together:

Drupal brand materials under core/misc/logo have a dedicated license. See
core/misc/logo/LICENSE.txt.

Additionally, I'd like to have signoff from someone in legal or at the DA before committing this. Calling that a "subsystem" maintainer for lack of a better term. :) I'll ask in a DA channel.

jungle’s picture

+++ b/core/misc/logo/LICENSE.txt
@@ -0,0 +1,3 @@
+Files in this directory do not fall under the GNU General Public License.
+See https://www.drupal.org/about/media-kit/copyright-and-trademark for
+license terms.

One more similar to #29. Even without moving See to the previous line, license should be.

hestenet’s picture

Additionally, I'd like to have signoff from someone in legal or at the DA before committing this. Calling that a "subsystem" maintainer for lack of a better term. :) I'll ask in a DA channel.

Consider it approved from your friendly neighborhood DA representative, as well as per Dries.

Note that in our other issue about drafting this language it was suggested to make the canonical language the text on Drupal.org itself so that additional tweaks can be easily made.

Therefore a suggested license.txt like @jungle'sabove should work.

Alternately, if we prefer to be extra safe, we could include the full text of the Drupal.org copyright and trademark policy for brand materials page, with a note at the top making it clear that the most current and official canonical version resides on D.O

dww’s picture

Status: Needs work » Needs review
Issue tags: -Needs subsystem maintainer review
StatusFileSize
new8.09 KB
new848 bytes

Re: #29 Fixed core/COPYRIGHT.txt per your suggestion. I wonder if we still want 'core' in the paths reference there, since this is core/COPYRIGHT.txt, so if you're reading that file, presumably you're already in the core subdir. But I left it as-is, since it seems fine this way, too.

Re: #30 Good catch. While I was at it, I figured I'd wordsmith that a little myself. "... do not fall under the [GPL]" seemed a bit informal and clumsy of a formulation. I went with:

The files in this directory are not covered by the GNU General Public License.
See https://www.drupal.org/about/media-kit/copyright-and-trademark for the
license terms of these Drupal brand materials.

Hope that's a "friendly amendment" as we say in Robert's Rules of Order. ;)

Re: #31:
- Yay for sign-off. Removing the tag @xjm added for that.
- Re: "if we prefer to be extra safe, we could include the full text of the..." -- that seems extra dangerous, not extra safe. Then we'll have N copies of this text, and lots of friction and trouble to change most of them. Plus stale versions already released that we can never change. A pointer to the One True Copy(tm) seems way safer and easier to maintain going forward. That's definitely the sense I get from reading #3134326: Adopt the 2020 (evergreen) Drupal logo in Drupal core, especially Dries's reply. So yeah, let's definitely not include any more text in core/misc/logo/LICENSE.txt than we have to. ;)

gábor hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

The text is good and resolves @xjm's concerns as well which I agree with. Also @hestenet signed off.

  • xjm committed 87faa11 on 9.0.x
    Issue #3137414 by shaal, dww, Gábor Hojtsy, sja112, codersukanta, jungle...
  • xjm committed 4801c4a on 9.1.x
    Issue #3137414 by shaal, dww, Gábor Hojtsy, sja112, codersukanta, jungle...

xjm credited Dries.

xjm’s picture

Status: Reviewed & tested by the community » Fixed

Yay! Glad to see us fixing this before RC (and in a way that meets our licensing needs without any real overhead for core). No egg on our face branding it as D8. And in some ways I'm glad we had this bug because this is at least one thing in the UI that's new, even though we weren't ready to turn on new themes etc.

Since this is changes to the internal themes, deleting the old logo is OK.

Committed to 9.1.x and cherry-picked to 9.0.x. Thanks!

dww’s picture

Excellent, thanks!

Moving this as a direct child of #3134326: Adopt the 2020 (evergreen) Drupal logo in Drupal core so that issue can more easily track children for specific uses of the new logo...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.