We should investigate improving the cache invalidation on views as a follow up to https://www.drupal.org/project/entityqueue/issues/2686623

Currently entity type cache tags (node_list) are invalidated on save of entity queues which was a work around until this task was complete - https://www.drupal.org/project/drupal/issues/2853592

CommentFileSizeAuthor
#2 improve-views-cache-invalidation-3134079-2.patch960 bytesocastle

Comments

ocastle created an issue. See original summary.

ocastle’s picture

ocastle commented
Status: Active » Needs review
StatusFileSize
new improve-views-cache-invalidation-3134079-2.patch960 bytes

I believe we can just remove the additional entity type list cache tag from the invalidation array. but if anyone can sanity check this that would be great.

amateescu’s picture

amateescu commented

We have to check at least if the problem mentioned in #2686623: Empty views cache when queue is updated does not happen anymore if we remove that workaround.

However, I think we mostly likely need to do a bit more here, like adding the subqueue ID to the view cache tags in our various handlers, as can be seen in the patch that was committed in #2853592: Cacheability metadata can't be set from within argument default handlers..

amateescu’s picture

amateescu commented
Status: Needs review » Needs work

NW per #3.