Problem/Motivation

For this particular site we have a feature called "featured content" which is a node reference for each term. These then appear at the top of the term page.
Sadly cacheability metadata wasn't picked up, when set to $this->view->element

Proposed resolution

Ensure that we carry over the cacheability metadata.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2853592-8-8.4.x.patch2.64 KBlendude
#8 2853592-8-8.3.x.patch2.63 KBlendude
#3 2853592-3.patch2.63 KBlendude
#3 interdiff-2853592-2-3.txt849 byteslendude
#2 2853592-2.patch2.55 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2853592-2.patch2.55 KB

Here is a patch+ test

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new interdiff-2853592-2-3.txt849 bytes
new 2853592-3.patch2.63 KB

Fixed a couple of nitpicks, rest looks good and makes sense.

jian he’s picture

jian he commented

Can this patch solve #2710679: Views handlers should be able to add cache tags to the views results cache?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Let's fix it then.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Needs work

I was going to fix this and also backport to 8.3.x, but the passion doesn't seem to apply. Can we get a reroll? Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Related issues: +#2580935: DisplayPluginBase::applyDisplayCachablityMetadata() method has typo in it's name

Looks like a conflict with #2580935: DisplayPluginBase::applyDisplayCachablityMetadata() method has typo in it's name.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Needs review
StatusFileSize
new 2853592-8-8.3.x.patch2.63 KB
new 2853592-8-8.4.x.patch2.64 KB

Here are a 8.4.x and 8.3.x version.

No change in the 8.3.x version since #3 but posting them together for sanity.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

  • xjm committed 7e50662 on 8.4.x 
    Issue #2853592 by Lendude, dawehner: Cacheability metadata can't be set...

  • xjm committed 4a9007d on 8.3.x 
    Issue #2853592 by Lendude, dawehner: Cacheability metadata can't be set...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Interestingly, the 8.4.x patch cherry-picked cleanly to 8.3.x also. Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.