Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
views.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Oct 2015 at 08:30 UTC
Updated:
7 Mar 2017 at 16:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
maijs commentedComment #3
dawehnerHa, good catch! Its an internal method so renaming should be fine.
Comment #7
Anonymous (not verified) commentedreroll for 8.2.x + add deprecated
applyDisplayCachablityMetadata()for BC, because it can be used in extended classes of contrib modules (eg. recipe, wechat) and may be some custom modules.Comment #8
berdirAdding the BC method makes sense to me. Also moving to views module.
Comment #9
alexpott8.3.0 and removed in Drupal 9.0.
Also just for lolz the new name still has a typo :)
Should be
applyDisplayCacheabilityMetadataPlus the reference here should be
DisplayPluginBase::applyDisplayCacheabilityMetadataand an@see \Drupal\views\Plugin\views\display\DisplayPluginBase::applyDisplayCacheabilityMetadata()should be added.Comment #10
Anonymous (not verified) commentedOops! I feel extremely uncomfortable for it. Sorry! This patch fixed #9 (i hope) + replace all cases with 'cacheblity' in core.
Comment #11
dawehnerI fear I might not be irresponsible for that particular typo :(
IMHO this should really just be fixed in 8.3.x
Comment #12
alexpottI think this needs to be
$this->applyDisplayCacheabilityMetadata($element);. BC layers with no tests :( I'm sorry that my comment might have lead to this unnecessary change.The rest looks good.
Comment #13
Anonymous (not verified) commentedComment #15
Anonymous (not verified) commented#13 patch need re-roll after #2815845: Importing (deploying) REST resource config entities should automatically do the necessary route rebuilding. Because one line was changed:
After this patch I was searching by
applyDisplayCachablityMetadata,cachaandblityand not found (only in deprecated part).Comment #16
dawehnerWorks for me. I am not sure whether its worth to test this BC layer. There is just one possible implementation of it.
Comment #17
alexpottThis will be deprecated in 8.4.0 - it has missed the boat for 8.3.0.
let's use the @trigger_error pattern here. Whilst it is not policy yet it will be 8.4.0.
@trigger_error('The DisplayPluginBase::applyDisplayCacheablityMetadata method is deprecated since version 8.4 and will be removed in 9.0. Use DisplayPluginBase::applyDisplayCacheabilityMetadata instead.', E_USER_DEPRECATED);Comment #18
Anonymous (not verified) commentedComment #19
dawehnerInteresting!
Comment #20
alexpottCommitted 9f2371f and pushed to 8.4.x. Thanks!
Lol in #17 I spelt the deprecated method name correctly and therefore wrong. Fixed on commit.