Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
For this particular site we have a feature called "featured content" which is a node reference for each term. These then appear at the top of the term page.
Sadly cacheability metadata wasn't picked up, when set to $this->view->element
Proposed resolution
Ensure that we carry over the cacheability metadata.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#8 | 2853592-8-8.4.x.patch | 2.64 KB | Lendude |
#8 | 2853592-8-8.3.x.patch | 2.63 KB | Lendude |
#3 | 2853592-3.patch | 2.63 KB | Lendude |
#3 | interdiff-2853592-2-3.txt | 849 bytes | Lendude |
#2 | 2853592-2.patch | 2.55 KB | dawehner |
Comments
Comment #2
dawehnerHere is a patch+ test
Comment #3
LendudeFixed a couple of nitpicks, rest looks good and makes sense.
Comment #4
jian he CreditAttribution: jian he commentedCan this patch solve #2710679: Views handlers should be able to add cache tags to the views results cache?
Comment #5
jibranLet's fix it then.
Comment #6
xjmI was going to fix this and also backport to 8.3.x, but the passion doesn't seem to apply. Can we get a reroll? Thanks!
Comment #7
xjmLooks like a conflict with #2580935: DisplayPluginBase::applyDisplayCachablityMetadata() method has typo in it's name.
Comment #8
LendudeHere are a 8.4.x and 8.3.x version.
No change in the 8.3.x version since #3 but posting them together for sanity.
Comment #9
jibranBack to RTBC.
Comment #12
xjmInterestingly, the 8.4.x patch cherry-picked cleanly to 8.3.x also. Committed, thanks!