Closed (fixed)
Project:
Metatag
Version:
2.0.x-dev
Component:
Twitter Cards
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Apr 2020 at 10:34 UTC
Updated:
14 Mar 2023 at 22:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
damienmckennaComment #3
damienmckennaComment #4
damienmckennaComment #5
damienmckennaComment #8
igork96 commentedHere is a patch for the request. Needs review.
Comment #10
damienmckennaThe first step is to mark the plugins "deprecated", then remove the files. Because we have two issues for this, we'll deprecate them in this issue in Metatag v1 and then remove them in #3132065: Remove deprecated Twitter Card plugins (D9) in Metatag v2.
Comment #11
damienmckennaIgnoring #10, refocusing this on just removing the expired card type values.
Comment #12
damienmckennaAnd now with an update script, the logic of which was borrowed from #3132065: Remove deprecated Twitter Card plugins (D9) so it should be ok.
Comment #13
damienmckennaComment #14
damienmckennaI'm moving this to v2 so that I can take advantage of the existing testing structure.
Comment #17
damienmckennaWIP that builds on #3336234.
Comment #18
damienmckennaComment #22
damienmckennaMore work, and documentation.
Comment #24
damienmckennaCommitted. Thanks for your contribution, igork96!
Comment #25
renatog commentedI think we can improve this logic to use "early return" on this condition, right?
Example:
Comment #26
renatog commentedPatch with one example
Comment #27
damienmckennaThank you. Committed.