Problem/Motivation

The following Twitter Card tags were dropped at some point and should be removed:

  • twitter:url
  • twitter:label1
  • twitter:label2
  • twitter:image:height
  • twitter:image:width
  • twitter:data1
  • twitter:data2
  • twitter:dnt
  • twitter:gallery:image0
  • twitter:gallery:image1
  • twitter:gallery:image2
  • twitter:gallery:image3

Proposed resolution

Remove the plugins.
Add update script to fix config.
Add update script to fix entity values.

Remaining tasks

Remove the plugins.
Add update script to fix config.
Add update script to fix entity values.

CommentFileSizeAuthor
#10 metatag-n3132065-10.patch24.74 KBdamienmckenna
#6 metatag-n3132065-6.patch13.3 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3132062: Remove deprecated Twitter Card types (D8) »
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Remove deprecated Twitter Card tags (D8) » Remove deprecated Twitter Card plugins (D9)
Version: 8.x-1.x-dev » 2.0.x-dev

This will be done in v2.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3272774: Plan for Metatag 2.0.0
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n3132065-6.patch13.3 KB

This removes the plugins.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Next off: update scripts.

  • DamienMcKenna committed d004e43b on 8.x-1.x 
    Issue #3132065 by DamienMcKenna: Updated fixtures with Twitter Cards...

  • DamienMcKenna committed b7253d76 on 2.0.x 
    Issue #3132065 by DamienMcKenna: Updated fixtures with Twitter Cards...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3132065-10.patch24.74 KB

Now with test coverage.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 5606a720 on 2.0.x 
    Issue #3132065 by DamienMcKenna: Remove deprecated Twitter Card plugins.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.