According to Twitter, the following card types are deprecated:

Not sure if you have already removed these card types from the 8.x version, etc. but it looks like they've been deprecated for 18 months at this point.

CommentFileSizeAuthor
#13 metatag-n2827909-13.patch8.17 KBDamienMcKenna
#11 metatag-n2827909-11.patch718 bytesDamienMcKenna
#5 remove_deprecated-2827909-5.patch4.62 KBcebasqueira
#3 edit_remove_deprecated-2827909-3.patch3.79 KBcebasqueira
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TynanFox created an issue. See original summary.

cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira at CI&T commented
Assigned: Unassigned » cebasqueira
cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira at CI&T commented
Assigned: cebasqueira » Unassigned
Status: Active » Needs review
FileSize
edit_remove_deprecated-2827909-3.patch3.79 KB

Status: Needs review » Needs work

The last submitted patch, 3: edit_remove_deprecated-2827909-3.patch, failed testing.

cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira at CI&T commented
FileSize
remove_deprecated-2827909-5.patch4.62 KB

Small changes on patch!

cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira at CI&T commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

Thanks for putting that together.

These needs update scripts to do a few things:

  • Convert all existing values from the older formats to the newer ones.
  • Delete the tags that are no longer supported.

FYI in metatag.install you can find metatag_update_replace_entity_value() and metatag_update_replace_config_value() which can be used to do the first fix, see metatag_hreflang.install for some example usage.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Remove Deprecated Twitter Card types » Remove Deprecated Twitter Card types (D7)
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Remove Deprecated Twitter Card types (D7) » Remove deprecated Twitter Card types (D7)
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3273409: Plan for Metatag 7.x-2.0

Let's get this into the v2 release.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2827909-11.patch718 bytes

Most of the changes went into #3132066: Remove deprecated Twitter Card tags (D7) so all that's left is the card type values.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: Unassigned » DamienMcKenna
Status: Needs review » Needs work

Needs an update script to fix the entity values and configuration:
* Product Cards: switch to Summary Card.
* Gallery Cards and Photo Cards: switch to Summary with Large Image card.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2827909-13.patch8.17 KB

Update scripts.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: #3273409: Plan for Metatag 7.x-2.0 » #3360481: Plan for Metatag 7.x-1.32

  • DamienMcKenna committed 2961dbe9 on 7.x-1.x 
    Issue #2827909 by DamienMcKenna, cebasqueira, TynanFox: Remove...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 82fcd0f4 on 7.x-2.x 
    Issue #2827909 by DamienMcKenna, cebasqueira, TynanFox: Remove...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: DamienMcKenna » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.