I am using a suffix for 1 of my form input and the rendering is not so good on edit mode as the suffix gets to a new line below my full width input (so looking quie weird)

Is it possible to use standard Bootstrap prefix & suffix for input as described here: https://getbootstrap.com/docs/4.0/components/input-group?

CommentFileSizeAuthor
#2 bootstrap_barrio-handle_prefix_suffix-3128006-2.patch1.19 KBvdsh

Comments

vdsh created an issue. See original summary.

vdsh’s picture

vdsh commented
Status: Active » Needs review
StatusFileSize
new bootstrap_barrio-handle_prefix_suffix-3128006-2.patch1.19 KB

I added a div class=input-group if we have a suffix or a prefix, and updated slightly the html for prefix & suffix to render them as in Bootstrap's documentation.

I have a couple of questions:
- For a reason I couldn't explain, adding the input-group class to the fieldset is not enough to make the input behaves properly. I couldn't understand why
- I first edited the fieldset.html.twig file before realizing it was not the one used, but form-element.html.twig was in fact the one used. Is this fieldset template used anywhere?

It's my first patch for a theme and I am in no way a twig expert, so please review & comment.

Status: Needs review » Needs work

The last submitted patch, 2: bootstrap_barrio-handle_prefix_suffix-3128006-2.patch, failed testing. View results

lolandese’s picture

lolandese commented
Status: Needs work » Needs review
Related issues: +#3134142: Provide a minimal PHPUnit test or disable automated testing

  • hatuhay committed 1ed7308 on 8.x-4.x authored by vdsh 
    Issue #3128006 by vdsh: Use Bootstrap prefix & suffix for form input
hatuhay’s picture

hatuhay commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.