Providing a patch for this module initially always changes the status from "Needs review" to "Needs work" by the automated test that is activated on the project. This is however not due to the patch but to the current absence of a test.

ERROR: No valid tests were specified.

It is recommended to disable automated testing at https://www.drupal.org/node/1997362/qa until at least a minimal test has been provided.

Searching 290 files for "Test" (case sensitive)

0 matches
CommentFileSizeAuthor
#5 bootstrap_barrio-add_basic_test-3134142-5.patch689 byteslolandese

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented

If interest is expressed by the current maintainer, I can provide a patch.

lolandese’s picture

lolandese commented
Issue summary: View changes
hatuhay’s picture

hatuhay commented

Please proceed. help welcome

lolandese’s picture

lolandese commented
Status: Active » Needs review
Related issues: +#2769599: [PP-1] Allow themes to be testable
StatusFileSize
new bootstrap_barrio-add_basic_test-3134142-5.patch689 bytes

The attached patch adds just a dummy test to run DrupalCI. This is only to check if issue queue patches apply cleanly.

System info of the used local environment

 Drupal version   : 8.8.5                                                 
 DB driver        : mysql                                                 
 PHP binary       : /usr/bin/php7.3

BEFORE patching (local PHPUnit test)

martin@martin-XPS-13-9370 /var/www/html/brown.localhost $ sudo -u www-data ./vendor/bin/phpunit -c ./web/core ./web/themes/contrib/bootstrap_barrio/ --debug --printer="\Drupal\Tests\Listeners\HtmlOutputPrinter"
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.



Time: 262 ms, Memory: 6.00 MB

No tests executed!

AFTER patching (local PHPUnit test)

martin@martin-XPS-13-9370 /var/www/html/brown.localhost $ sudo -u www-data ./vendor/bin/phpunit -c ./web/core ./web/themes/contrib/bootstrap_barrio/ --debug --printer="\Drupal\Tests\Listeners\HtmlOutputPrinter"
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing ./web/themes/contrib/bootstrap_barrio/
Test 'Drupal\Tests\bootstrap_barrio\Kernel\BootstrapBarrioTest::testBootstrapBarrioCore' started
Test 'Drupal\Tests\bootstrap_barrio\Kernel\BootstrapBarrioTest::testBootstrapBarrioCore' ended


Time: 1.08 seconds, Memory: 6.00 MB

OK (1 test, 2 assertions)

Code quality

Passes both Codesniffer Drupal and Drupal Practice.

Deprecations (D9 prep)

No deprecations found:

martin@martin-XPS-13-9370 /var/www/html/brown.localhost/web/themes/contrib $ drupal-check bootstrap_barrio/
 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                
 [OK] No errors
lolandese’s picture

lolandese commented

Yes. We now get a green-labeled confirmation that the DrupalCI test passed on the supplied patch.

This makes managing the issue queue a bit easier as we already know if supplied patches apply cleanly.

  • hatuhay committed 7ee7c88 on 8.x-4.x authored by lolandese 
    Issue #3134142 by lolandese: Provide a minimal PHPUnit test or disable...
hatuhay’s picture

hatuhay commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.