drupal_verify_install_file sometimes issues a php warning [#312677]

Hi,
when you call drupal_verify_install_file with the flag FILE_READABLE for a nonexistant, in a call by drupal_verify_install_file a php function is called which issues a warning for the nonexistant file. file_exists() is used in previous code, but in a way which makes it senseless...
The attached file return immediatly false if the file isn't of the expected type or doesn't exist. This check is entirely performed by the is_xx()-func.
The old misbehauvior needed to subsequent calls to drupal_verify_install_file which are unneeded.

Comment	File	Size	Author
#12	inc_install_drupal_install_fix_file.patch	810 bytes	CorniI
#12
#10	inc_install_drupal_install_fix_file.patch	909 bytes	CorniI
#10
#7	inc_install_drupal_install_fix_file.patch	738 bytes	CorniI
#7
#5	inc_install_drupal_install_fix_file.patch	737 bytes	CorniI
#5
#1	install.inc-drupal_verify_install_file.patch	4.06 KB	Anonymous (not verified)
#1
	drupal_ver_install.patch	679 bytes	CorniI

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 24 September 2008 at 12:18

File	Size
install.inc-drupal_verify_install_file.patch	4.06 KB

I think we need to retain the $return and make the changes I have attached.

Comment #2

catch

he/him

English

CreditAttribution: catch commented 24 September 2008 at 12:47

Not tested the patch yet, but this is to prevent errors if you mv default.settings.php instead of cp default.settings.php since the installer requires both default.settings.php and settings.php to actually work.

Comment #3

CorniI CreditAttribution: CorniI commented 24 September 2008 at 13:15

Nah, it's not the real patch, it's a bug I found when writing that patch ;)
The one of earnie doesn't work. I maybe have to explain better where the problem really lies: Even when a file doesn't exist drupal calls drupal_install_fix_file() for the file, which issues a call to fileperms() which then issues a stat failure:
Warning: fileperms() [function.fileperms]: stat failed for ./sites/default/default.settings.php in /var/www/drupal7/includes/install.inc on line 740
One may want to fix the problem there, too. But if a file is nonexistant most of the loop in drupal_verify_install_file is nonsense, too. The only logical thing (for me) would be passing a dir to the drupal_install_mkdir() and FILE_EXIST, the rest would just leed to failure-calls to is_xxx() and drupal_install_fix_file()