remove the core key so the module's tests work with Drupal 9.

CommentFileSizeAuthor
#3 3122349-3.patch872 byteskatherined
#2 3122349-2.patch534 byteskatherined

Comments

katherined created an issue. See original summary.

katherined’s picture

katherined
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3122349-2.patch534 bytes

Patch

katherined’s picture

katherined
she/her
Primary language English
commented
StatusFileSize
new 3122349-3.patch872 bytes

What if I remove the media_entity_embeddable_video test dependency?

sam152’s picture

sam152 commented

I think test dependencies are downloaded from HEAD, so removing the test dependency in a patch may not indicate if it's required or not? I believe there was a tested upgrade path from media_entity_embeddable_video to video_embed_media.

sam152’s picture

sam152 commented

Okay, nevermind, the upgrade path from that module was removed in #2902316: Create a port of video_embed_media compatible with media in core API.

sam152’s picture

sam152 commented
Status: Needs review » Fixed

  • Sam152 committed 0da9a75 on 8.x-2.x authored by katherined 
    Issue #3122349 by katherined: Remove core key from test module info file

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.