Problem/Motivation

Visibility must be declared on method "__construct"

Proposed resolution

Add visibility public to __construct method

CommentFileSizeAuthor
#5 3119728_2-5.txt11.46 KBswatichouhan012
#5 3119728-5.patch13.49 KBswatichouhan012
#2 pathauto-Visibility_must_be_declared_on_method_construct-3119728-2-D8.patch915 bytesthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
pathauto-Visibility_must_be_declared_on_method_construct-3119728-2-D8.patch915 bytes

Follow a patch

swatichouhan012’s picture

swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commented
Assigned: Unassigned » swatichouhan012
Status: Needs review » Needs work
Issue tags: +VbContribution2020

There is more same type issue other files, lets increase the scope of this issue and fix in complete module.

swatichouhan012’s picture

swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commented
Title: Visibility must be declared on method "__construct" » Visibility must be declared on method fixes.
swatichouhan012’s picture

swatichouhan012 CreditAttribution: swatichouhan012 at Valuebound for Valuebound commented
Assigned: swatichouhan012 » Unassigned
Status: Needs work » Needs review
FileSize
3119728-5.patch13.49 KB
3119728_2-5.txt11.46 KB

I have updated patch to mix visibility method error, kindly review.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs review » Reviewed & tested by the community

Thanks @swatichouhan012!
Looks good to me!

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • Berdir committed 2940dae on 8.x-1.x authored by swatichouhan012 
    Issue #3119728 by swatichouhan012, thalles: Visibility must be declared...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.