Drupal 9 readiness

Patch applies.

Also added related issue.

RTBC++

RTBC++

RTBC++

Can we get this merged?

Shouldn't this include the \Drupal::l() => Link::fromTextAndUrl() conversion mentioned in #3087361: Drupal 9 Deprecated Code report?

You can, but it's normally better to keep things separated no?

I suggest to first merge #3087361 so that all deprecations are gone, and then this one to make it fully D9 ready.

As of yesterday, you can make changes to composer.json in a patch to make the project support drupal/core: ^8.0 || ^9.0 and run tests on the testbot. Wouldn't it make sense to make those changes and incorporate any fixes to make it support 9.0 at the same time?

Fix D9 readlines completely

tests failed.

Please review!

Tests are passing. LGTM.

getting error

composer require 'drupal/yoast_seo:1.x-dev'
Problem 1
- Conclusion: remove doctrine/annotations 1.10.3
- Conclusion: don't install doctrine/annotations 1.10.3

composer require 'drupal/yoast_seo:2.x-dev'
Problem 1
- Installation request for drupal/yoast_seo 2.x-dev -> satisfiable by drupal/yoast_seo[2.x-dev].
- Conclusion: remove drupal/core 9.0.2
- Conclusion: don't install drupal/core 9.0.2

@Rar9 It's because you need to apply this patch from git (not from the composer). I can confirm that patch is fine.

I just added patch 14 to composer.json

            "drupal/yoast_seo": {
                "fix d9 ": "https://www.drupal.org/files/issues/2020-07-13/3119603-14.patch"
            }

and the run composer require...

Why do i need to look for a patch somewhere at git?

Please if you can spare time to commit this issue to the dev branch that will be nice.
A release after that will have a support for Drupal 9 build.
as this issue is a blocker issue for
#3122672: Start a 9.0.x branch for Varbase and Varbase Project to integrate with Drupal 9

Real physical testing with Drupal 9 is important as Drupal 9.0.5 went out

Thanks for having time to work on this nice and very useful module.

I created a fork applying #14 in case someone need to use this project with D9 https://github.com/Metadrop/yoast_seo

It would be nice to merge that issue, it is pretty annoying to have to make a fork just to use the module.

+1 for getting this merged as it's RTBC.

Anything else that the maintainers are blocked by?

I guess the maintainers are not active anymore.

So I guess we have to wait for #3173941: Offering to co-maintain Real-time SEO for Drupal

Maybe people can ping on this issue to speedup the process #3169265: Offering to co-maintain Real-time SEO for Drupal

Thanks for everyone's help on this issue, 2.0-alpha4 has been released.

This patch applied to 2.x (contrary to the issue's selected version) so work is still needed for 1.x. #3149492: Automated Drupal 9 compatibility fixes contains a start for 1.x

Thank you so much!