13/13 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------------------------
Line src/Controller/SettingsController.php
------ ----------------------------------------------------------
41 Call to deprecated method l() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Link instead.
Example:
60 Call to deprecated method l() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Link instead.
Example:
100 Call to deprecated method l() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Link instead.
Example:
------ ----------------------------------------------------------

[ERROR] Found 3 errors

CommentFileSizeAuthor
#11 single-export-yoast_seo-2020-07-01T12_48_27+0530.txt1.42 KBBalajiDS
#10 addedD9Readlines-3087361-10.patch2.32 KBedycarreyes99
#10 interdiff-3087361-2-10.txt2.32 KBedycarreyes99
#2 yoast_seo-deprecated_code-3087361-2.patch1.76 KBlilit_ghazaryan

Comments

Lilit_Ghazaryan created an issue. See original summary.

lilit_ghazaryan’s picture

lilit_ghazaryan commented
StatusFileSize
new yoast_seo-deprecated_code-3087361-2.patch1.76 KB

13/13 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

lilit_ghazaryan’s picture

lilit_ghazaryan commented
Status: Needs work » Needs review
Kate.Y’s picture

Kate.Y commented
Status: Needs review » Reviewed & tested by the community

drupal-check yoast_seo/
13/13 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

Branch : 8.x-2.x-dev
Patch works fine.

stefdewa’s picture

stefdewa commented

+1 for RTBC

mpp’s picture

mpp commented

RTBC++

komalk’s picture

komalk commented
Issue tags: +Drupal 9 porting weekend, +DIACWMay2020
trebormc’s picture

trebormc
Primary language Catalan
commented

RTBC++

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

RTBC++

edycarreyes99’s picture

edycarreyes99 commented
Assigned: lilit_ghazaryan » edycarreyes99
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff-3087361-2-10.txt2.32 KB
new addedD9Readlines-3087361-10.patch2.32 KB

I found some warnings yet and I fixed on the next patch:

CUSTOM PROJECTS
--------------------------------------------------------------------------------
Real-time SEO for Drupal
Scanned on Tue, 06/30/2020 - 23:55.

2 warnings found.

web/modules/contrib/yoast_seo/yoast_seo.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/yoast_seo/composer.json:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ The drupal/core requirement is not Drupal 9 compatible.    │
│ manually │      │ Either remove it or update it to be compatible with Drupal │
│          │      │ 9. See                                                     │
│          │      │ https://drupal.org/node/2514612#s-drupal-9-compatibility.  │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘
BalajiDS’s picture

BalajiDS commented
StatusFileSize
new single-export-yoast_seo-2020-07-01T12_48_27+0530.txt1.42 KB

patch #10 works fine but after applying patch one warning message found.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Assigned: edycarreyes99 » Unassigned
Status: Needs review » Reviewed & tested by the community
Related issues: +#3119603: Drupal 9 readiness, +#3149492: Automated Drupal 9 compatibility fixes

This is deprecated code report, not Drupal 9 readiness as in this issue https://www.drupal.org/project/yoast_seo/issues/3119603

Don't mix patches please and keep issues to only fixing one thing at the time :)

Back to RTBC and hidden patch #10

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Critical

Please if you can spare time to commit this issue to the dev branch that will be nice.
A release after that will have a support for Drupal 9 build.
as this issue is a blocker issue for
#3122672: Start a 9.0.x branch for Varbase and Varbase Project to integrate with Drupal 9

Real physical testing with Drupal 9 is important as Drupal 9.0.5 went out

Thanks for having time to work on this nice and very useful module.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for everyone's help on this issue, 2.0-alpha4 has been released.

This patch applied to 2.x (contrary to the issue's selected version) so work is still needed for 1.x. #3149492: Automated Drupal 9 compatibility fixes contains a start for 1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.