CommentFileSizeAuthor
#7 drupal-practice-errors-3117686-7.patch23.16 KBnarendra.rajwar27
#2 drupal-practice-errors-3117686-2.patch24.21 KBakshay_d
Screenshot 2020-03-04 at 3.53.22 PM.png429.09 KBakshay_d

Issue fork url_redirect-3117686

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Location Bangalore
commented
Assigned: akshay_d » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-practice-errors-3117686-2.patch24.21 KB

Fixed all the practice errors and injected dependency
, please review

JeroenT credited Maithri Shetty.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Needs work

Patch no longer applies.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
commented
Assigned: Unassigned » narendra.rajwar27
narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-practice-errors-3117686-7.patch23.16 KB

Re-rolled the patch in #2.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
commented
Assigned: narendra.rajwar27 » Unassigned

I have no clue that it is still assigned to me. Unassigning the issue.

takuma shimabukuro’s picture

takuma shimabukuro commented
Assigned: Unassigned » takuma shimabukuro
Status: Needs review » Reviewed & tested by the community

Hi narendra.rajwar27 , I ran the phpcs commands, but it still show error to me.
I fixed it on issue I found a lot of format errors in the module..
Please review it.

takuma shimabukuro’s picture

takuma shimabukuro commented
Assigned: takuma shimabukuro » Unassigned

foxy-vikvik made their first commit to this issue’s fork.

foxy-vikvik’s picture

foxy-vikvik commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
Issue tags: +LutskGCW26
foxy-vikvik’s picture

foxy-vikvik commented
Version: 8.x-3.x-dev » 4.0.x-dev
foxy-vikvik’s picture

foxy-vikvik commented
Status: Reviewed & tested by the community » Closed (duplicate)

Duplicate the issue: https://www.drupal.org/project/url_redirect/issues/3228984

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

grask0’s picture

grask0 commented

Ok, thanks!