Don't create new items, only update existing (D8)

Yes, this is a thing still to be done indeed. It would be nice to have it done before the beta phase, so I added it as a beta target.

Hi @MegaChriz

I have created initial patch for this functionality.

@goveind.maloo
Your patch works for me. Tested a couple of times so far with success.
Thanks.

+++ b/src/Feeds/Processor/Form/DefaultEntityProcessorForm.php
@@ -71,6 +71,16 @@ class DefaultEntityProcessorForm extends ExternalPluginFormBase implements Conta
+      '#title' => t('Insert new @entities', $tokens),
+      '#description' => t('New @entities will be determined using mappings that are a "unique target".', $tokens),

could use $this->t() instead of t()

I tried to test this patch, but I am not sure what it is actually supposed to do - is there a new option in processor settings?

@irinaz in your feed settings admin/structure/feeds/manage/FEEDSNAME
under Processor Settings there's a new option : Insert new product variations

I tested
- processors : Product & Product Variation
- fetcher : Upload file & Directory
- Parser : cvs

Works great for me! Thanks!

Setting back to needs work as per #5

@jcnventura, can you see updates from #5 in this fork https://git.drupalcode.org/issue/feeds-3116987/-/compare/8.x-3.x...31169... ? There is no additional patch for this change.

Indeed, but until you create a Merge Request, that issue fork is invisible here. Please do set it back to Needs Review when there's an MR to review.

@jcnventura, thanks for clarification, I created merge request and changed to "needs review".

Thanks for the MR. The failing tests are also failing for the base module.

I think it only needs two things now:

1. Tests
2. For consistency sake, remove the FEEDS_ prefix from the new constants.

@irinaz, thanks for that. The FEEDS_ prefix was still present in:

• lines 79 and 80 of src/Feeds/Processor/Form/DefaultEntityProcessorForm.php
• lines 41 and 48 of src/Plugin/Type/Processor/ProcessorInterface.php

I've removed those, and I hope that the tests will pass again

@jcnventura, thanks for fixing it!

I added test coverage for this feature. The tests are inspired by tests for the same feature in the D7 version: FeedsRSStoNodesTest::testSkipNewItems().

I also flipped the constant values: SKIP_NEW now is 0 and INSERT_NEW now is 1. This is consistent with what the values were in the D7 version of Feeds:

// Insert mode for new items.
define('FEEDS_SKIP_NEW', 0);
define('FEEDS_INSERT_NEW', 1);

Taken from plugins/FeedsProcessor.inc from Feeds 7.x-2.x

I guess that means the title should be like this then...

@jcnventura
No, not really. The new feature is that you can prevent Feeds for creating new content. Creating new items and don't update existing is a feature already available in Feeds.

Hided the patch to decrease confusion, the latest code is in an issue fork now.

I inspected the code one more time and only made some small aesthetic changes.

The code has been merged!