Comments

Sivaji created an issue. See original summary.

sonvir249’s picture

Status: Active » Needs review
StatusFileSize
new933 bytes
new152.47 KB

Removed route weight from links file.

hardik_patel_12’s picture

Status: Needs review » Reviewed & tested by the community

Patch #2 looks good to me, so making it RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs usability review

Hmmm - well I think the idea is to have the recent log entries at the top of the list bu once you have the updates module installed that's no longer the case and it results in the odd order. I think given that there has been in the past an intention to order these links we need to carefully consider the UX aspects of the order of this list before changing it to the default.

webchick’s picture

Alex asked us to look at this as part of the weekly #ux meeting. Video at https://youtu.be/PpyHgnstVUE; discussion of this issue starts around 20 mins in.

@alexpott is correct that the weighting was done intentionally at #787944: Weight items on the Reports overview page. (Weirdly, we seem to have somehow lost the Status update being at the top over the years?)

I think the reason this (rightfully) confused @Sivaji, however, is because we are using weights as the only (substandard) tool available for what we really want, which is #2695177: Visual and structural hierarchy: ways to emphasize admin items over others. So it does indeed look buggy, when for example "Structure" is just in regular alphabetical order.

However, we do employ this "strategic reordering" in other places (e.g. /configure, putting "Performance" at the top of the "Development" category), so from that POV this is working "by design."

I can see a few possible options:

1) Close this issue as by design, put some effort into #2695177: Visual and structural hierarchy: ways to emphasize admin items over others in Seven/Claro to develop useful patterns for this. (The video kinda muses on this some; for example giving anything with a - weight bold styling, or a larger font, or a <hr /> separator...)
2) Move "Status updates" up there as well, like it used to be, so maybe(?) it looks a bit more intentional that we put certain "oft-used" options at the top
3) Both? :P
4) Neither? :P

Thoughts? :)

webchick credited tedbow.

webchick’s picture

Adding folks from the UX meeting.

webchick’s picture

Issue tags: -Needs usability review
benjifisher’s picture

StatusFileSize
new136.63 KB

I was part of the Usability meeting today, and I agree with the points in #5 (but I think you meant "Status report" instead of "Status updates").

Personally, I am in favor of working on a more comprehensive review of the menu structure in #2755613: Restructure the admin interface Information Architecture, and I do not want to make any such changes without some user testing.

I also want to point out that the order on the Reports page is the same as the order in the admin toolbar. You can see this if you use the toolbar in vertical mode, or with the contrib Admin Toolbar module. Here is a screenshot using the Umami demo profile:

Screenshot of the Reports page and the admin toolbar in vertical mode

aaronmchale’s picture

In reference to what @benjifisher said in #13 (and I mentioned this during last weeks meeting but just to also put it here for clarity), but for anyone who isn't aware of the inner workings of those admin list pages, the list of links is generated entirely from whatever is in the corresponding menu directly below the list page.

Controller method is \Drupal\system\Controller\SystemController::systemAdminMenuBlockPage, interestingly to generate a route which has that list, it's as simple as adding a new entry in a .routing.yml file:

module.route_name:
  path: '/route-path'
  defaults:
    _controller: '\Drupal\system\Controller\SystemController::systemAdminMenuBlockPage'
    _title: 'Title'

Which is super handy if you're creating a module that creates new admin pages.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

tanubansal’s picture

StatusFileSize
new289.52 KB

admin/reports menu items are not sorted on drupal 9.1.
Please provide patch for 9.1

abhijith s’s picture

StatusFileSize
new61.25 KB

patch #2 is not working for 9.1.x
Screenshot after patch:
patch

abhijith s’s picture

Status: Needs review » Needs work
anmolgoyal74’s picture

Status: Needs work » Needs review
StatusFileSize
new65.63 KB
new29.71 KB
new68.8 KB
new35.3 KB

#2 Working fine for me.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

ranjith_kumar_k_u’s picture

StatusFileSize
new925 bytes

Re-rolled for 9.2.x-dev

djsagar’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new68.8 KB
new35.3 KB
new65.63 KB
new29.71 KB

Patch #21 is Working fine in drupal 9.2.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

The usability team has reviewed this in #5 and #13 and neither comment was +1. Both are looking to integrate this into larger pieces of work - #2695177: Visual and structural hierarchy: ways to emphasize admin items over others and #2755613: Restructure the admin interface Information Architecture. This issue cannot be rtbc until those comments are addressed.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

rinku jacob 13’s picture

StatusFileSize
new71.23 KB
new77.4 KB

Patch #21 is Working fine in drupal 9.3.x-dev.thank's @ranjith_kumar_k_u .

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

StatusFileSize
new79.05 KB
new63.65 KB

Applied #2 patch working fine and applied successfully
Thanks for the patch
For ref sharing screenshot...

hmendes’s picture

Issue tags: +Needs usability review

I was taking a look at this issue, what is going to be done regarding the options in #5?

I can see a few possible options:

1) Close this issue as by design, put some effort into #2695177: Visual and structural hierarchy: ways to emphasize admin items over others in Seven/Claro to develop useful patterns for this. (The video kinda muses on this some; for example giving anything with a - weight bold styling, or a larger font, or a <hr /> separator...)
2) Move "Status updates" up there as well, like it used to be, so maybe(?) it looks a bit more intentional that we put certain "oft-used" options at the top
3) Both? :P
4) Neither? :P

The 'Status Report' page was at the top of the page in Drupal 7 after #787944: Weight items on the Reports overview page and after a looooooong time, I think I found when they removed it in Drupal 8: #1987824: Convert system_php() to a new style controller, although I didn't understand why it was removed.

Should we but it back to the top of the page?
Should we close this one to focus on #2695177: Visual and structural hierarchy: ways to emphasize admin items over others and maybe put the 'Status Report' back to the top of the page?

IMO we can close this issue and focus on #2695177: Visual and structural hierarchy: ways to emphasize admin items over others and send a patch there putting the 'Status Report' page back to the top of the page...

And as @alexpott said in #23, "This issue cannot be rtbc until those comments are addressed."

hmendes’s picture

Issue tags: -Needs usability review
StatusFileSize
new86.04 KB

Hello,

We discussed this issue in today's UX meeting on slack ( #3257468: Drupal Usability Meeting 2022-01-14 ) and it was decided that it seems like the issue #1987824: Convert system_php() to a new style controller removed the weight from the "Status Report" menu unintentionally and we should put it back to the top of the page.

Also was pointed that the admin user can change the order of the menus on /admin/structure/menu/manage/admin:

benjifisher’s picture

Status: Needs work » Closed (works as designed)

I am closing this issue: works as designed.

I opened #3259953: Status report should be near the top of the Reports menu to prioritize the Status report. I transferred issue credit from this issue to the new one.

I considered re-purposing this issue instead of creating a new one. I decided it is best to leave this one as is, with its current title, in case someone else gets the idea to make the menu items alphabetical. A secondary benefit is that anyone working on the new issue will be able to skip several comments that are preserved here.