The event registration field group is appearing above the dates field group on the event series form.
- weekly
- monthly
- custom
Please see screenshot.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | recurring_events_3114533_16.patch | 6.77 KB | mrpauldriver |
| #15 | recurring_events_3114533_15.patch | 1.25 KB | mrpauldriver |
| #11 | recurring_events_3114533_11.patch | 1.25 KB | Snehal Brahmbhatt |
| #9 | Screen Shot 2020-03-14 at 12.21.57 am.png | 96.19 KB | the_glitch |
| #4 | Screen Shot 2020-02-21 at 2.14.23 PM.png | 90.55 KB | owenbush |
Comments
Comment #2
the_glitch commentedLooks like you forgot to attach the screenshot Paul.
Comment #3
mrpauldriver commentedWell spotted.
Comment #4
owenbush commentedPaul. Can you let me know if your installation is one which maybe pre-dated the addition of the consecutive/daily recurrence types?
I don't see this issue on a fresh install, but I do recall at one point seeing something similar when additional elements (like registration) were added to an existing install and the field weightings were a little off.
You should be able to drag the fields into a more appropriate order in the Manage Form Display for a particular event series type.
Attached is a screenshot of what the default ordering should be.
Comment #5
owenbush commentedComment #6
mrpauldriver commentedThis is a fresh install before any modifications, also validated on simplytest.me. The registration module should also be enabled.
To notice it, you'll need to view the field ordering on the form display, or toggle between the different recur types on the actual form.
I did flag something similar once before, although the ordering problem back then was for different fields. See https://www.drupal.org/project/recurring_events/issues/3088915#comment-1...
Notwithstanding this issue, I've been thinking about the ordering of the registration settings for the default event series, as they are currently sandwiched in between the recur type date fields and the date inclusions and exclusions. This seems wrong.
It probably make more sense for the registration options to appear either before or after 'all' the date fields.
Whether they go before or after is a matter for consideration, but on balance I am thinking they should go before. I say this because if the registration module has been enabled, then registrations were probably an important reason for installing recurring_events in the first place. And, after looking at the code, this may also be more maintainable, in the event of more recur types being developed.
Obviously this can all be customised, so I am just thinking about first impressions and the ux for a default installation without modification.
Comment #7
the_glitch commentedI can confirm this is happening on my sites as well. Daily and Consecutive are the only recur type field sets that appear before the the Event Registration field set.
Also just as a side note, it would make more grammatical sense to have the first checkbox in the Event Registration field set pluralised as 'Enable Registrations'
Comment #8
owenbush commentedComment #9
the_glitch commentedComment #10
owenbush commentedComment #11
Snehal Brahmbhatt commented@MrPaulDriver @the_glitch @owenbush Please find this patch to resolve the above-mentioned issue.
Hope this works for you flawlessly!
Thanks,
Snehal Brahmbhatt
https://www.drupal.org/user/3147795/track
Comment #12
Snehal Brahmbhatt commentedComment #13
mrpauldriver commentedThank you for working on this @snehal-brahmbhatt. I confirm your patch fixes the ordering problem.
Comment #14
mrpauldriver commentedActually, I just noticed this patch breaks placement of the 'authored by' field.
Comment #15
mrpauldriver commentedWeight of 10 seems to work.
Comment #16
mrpauldriver commentedNoticed that when creating a new bundle, the field display weights were not in keeping with the default bundle.
This patch attempts to correct this.
Comment #18
owenbush commentedThanks all. This patch has been merged. Marking as fixed.