The event registration field group is appearing above the dates field group on the event series form.

- weekly
- monthly
- custom

Please see screenshot.

Comments

MrPaulDriver created an issue. See original summary.

the_glitch’s picture

Looks like you forgot to attach the screenshot Paul.

mrpauldriver’s picture

StatusFileSize
new136.28 KB

Well spotted.

owenbush’s picture

StatusFileSize
new90.55 KB

Paul. Can you let me know if your installation is one which maybe pre-dated the addition of the consecutive/daily recurrence types?

I don't see this issue on a fresh install, but I do recall at one point seeing something similar when additional elements (like registration) were added to an existing install and the field weightings were a little off.

You should be able to drag the fields into a more appropriate order in the Manage Form Display for a particular event series type.
Attached is a screenshot of what the default ordering should be.

owenbush’s picture

Status: Active » Postponed (maintainer needs more info)
mrpauldriver’s picture

Status: Postponed (maintainer needs more info) » Active

This is a fresh install before any modifications, also validated on simplytest.me. The registration module should also be enabled.

To notice it, you'll need to view the field ordering on the form display, or toggle between the different recur types on the actual form.

I did flag something similar once before, although the ordering problem back then was for different fields. See https://www.drupal.org/project/recurring_events/issues/3088915#comment-1...

Notwithstanding this issue, I've been thinking about the ordering of the registration settings for the default event series, as they are currently sandwiched in between the recur type date fields and the date inclusions and exclusions. This seems wrong.

It probably make more sense for the registration options to appear either before or after 'all' the date fields.

Whether they go before or after is a matter for consideration, but on balance I am thinking they should go before. I say this because if the registration module has been enabled, then registrations were probably an important reason for installing recurring_events in the first place. And, after looking at the code, this may also be more maintainable, in the event of more recur types being developed.

Obviously this can all be customised, so I am just thinking about first impressions and the ux for a default installation without modification.

the_glitch’s picture

I can confirm this is happening on my sites as well. Daily and Consecutive are the only recur type field sets that appear before the the Event Registration field set.

Also just as a side note, it would make more grammatical sense to have the first checkbox in the Event Registration field set pluralised as 'Enable Registrations'

owenbush’s picture

Component: Code » Recurring Events (Main module)
the_glitch’s picture

StatusFileSize
new96.19 KB

Only local images are allowed.

owenbush’s picture

Snehal Brahmbhatt’s picture

StatusFileSize
new1.25 KB

@MrPaulDriver @the_glitch @owenbush Please find this patch to resolve the above-mentioned issue.

Hope this works for you flawlessly!

Thanks,
Snehal Brahmbhatt
https://www.drupal.org/user/3147795/track

Snehal Brahmbhatt’s picture

Status: Active » Needs review
mrpauldriver’s picture

Status: Needs review » Reviewed & tested by the community

Thank you for working on this @snehal-brahmbhatt. I confirm your patch fixes the ordering problem.

mrpauldriver’s picture

Status: Reviewed & tested by the community » Needs work

Actually, I just noticed this patch breaks placement of the 'authored by' field.

mrpauldriver’s picture

Status: Needs work » Needs review
StatusFileSize
new1.25 KB

Weight of 10 seems to work.

mrpauldriver’s picture

StatusFileSize
new6.77 KB

Noticed that when creating a new bundle, the field display weights were not in keeping with the default bundle.

This patch attempts to correct this.

  • owenbush committed c70a5e8 on 8.x-1.x authored by MrPaulDriver
    Issue #3114533 by MrPaulDriver, Snehal Brahmbhatt, owenbush, the_glitch...
owenbush’s picture

Status: Needs review » Fixed

Thanks all. This patch has been merged. Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.