Closed (fixed)
Project:
Contact Emails
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Feb 2020 at 11:12 UTC
Updated:
5 Oct 2023 at 07:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
scott_euser commentedThanks for adding this option! Generally looks fine but just a couple things and one question
Coding standards should be $allowed_values = ... as its not a property of the class
Is it possible that this is empty and causes a notice?
Comment #3
ruuds commented@scott_euser thank you for your feedback.
1. Is fixed in the attached patch
2. $allowedValues[$email['value']]['emails'] will only be empty or not set when an invalid value is posted to the form, which will not happen in normal situations
3. I've added a test in the attached patch.
Comment #4
ruuds commentedComment #5
matt bI need this as I use Options email. I could not get the patch in #3 to apply to either 8.x-1.x-dev or 8.x-1.20 (no surprise - it's two years old!)
I got the following error on 8.x-1.20
So I removed the ContactEmailsTestBase and ContactEmailsRecipientTest elements from the patch and it then applied. I've tested it and it all works fine. I'd have been happy to move this to RTBC if I hadn't hacked the patch.
I've attached the 'hacked' patch file, but you really need to re-instate the test stuff I guess?
Comment #6
matt bCould whoever maintains this module move this forward please?
Comment #7
matt bHas this been applied?
Comment #8
ruuds commentedNo, doesn't seem to be applied looking at the source code.
Comment #10
scott_euser commentedApologies for the huge delay here. The clients I work for have all switched to Webform, so I will mark this module as seeking co-maintainers to help speed things up in the future.
Comment #11
matt bThank you!
Comment #12
ruuds commentedThanks!